March 2019 - Koha-bugs - lists.koha-community.org

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #14 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 87082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87082&action=ed… Bug 10577: (QA follow-up) Remove tab chars Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87010|0 |1 is obsolete| | --- Comment #13 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 87081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87081&action=ed… Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87009|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 87080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87080&action=ed… Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton <gmc(a)esilibrary.com> Rescued-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22593 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 [Bug 22596] html TT filter is breaking items search with custom field -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14109] ability to do multiple custom field searches on item search
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14109 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |fridolin.somers(a)biblibre.co | |m --- Comment #1 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Works now, maybe thanks to Bug 18542 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7890] Highlight required field in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Bug 7890 depends on bug 22399, which changed state. Bug 22399 Summary: Improve responsive behavior of the basic marc editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21623] New: Cron job to fix SMS numbers
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '19

27 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21623 Bug ID: 21623 Summary: Cron job to fix SMS numbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle(a)bywatersolutions.com Reporter: jesse(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Work to be done: 1 - Add HTML validation to the SMS number input to prevent use of non-numeric characters Can we allow people to put in punctuation but just not display/store it? So rather than having someone enter (603) 516-6050 and getting an error message can that be translated into 6035166050? Yes both OPAC and Staff Side. Also: > Can we allow people to put in punctuation but just not display/store -- You are receiving this mail because: You are watching all bug changes.

1 1