March 2019 - Koha-bugs - lists.koha-community.org

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #24 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86939&action=ed… Bug 17746: (QA follow-up) Make set_password.pl generate a password if required This patch makes the set_password.pl script generate the password if it is not passed as an argument. It also changes the behaviour of set_password.pl: it will now print the userid and password (generated or not) to mimick the behaviour from koha-reset-passwd. The koha-reset-passwd gets simplified as it doesn't generate the random password anymore, it passes the responsability to set_password.pl To test: - Follow the steps from the original platch - Verify all behaves as expected Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #23 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86938&action=ed… Bug 17746: Add misc/admin/set_password.pl script This patch introduces a script that allows changing a patron's password. The change overrides the defined password enforcement policy. If multiple conditions are passed to match on the patron, they all need to match. Otherwise an error message is printed. Attributes to search the patron on: - cardnumber - patron_id (a.k.a. borrowernumber) - userid we usually know some of them, but if we specify more than one, they need to match a patron, together. To test: 1) Apply this patch 2) Have a known patron (i.e. you know the cardnumber, the borrowernumber and the userid). 3) Run: $ kshell k$ perl misc/admin/set_password.pl --cardnumber <the_card_number> \ --password a_password 4) Verify you can login with the new password 5) Repeat 3) through 5) with --patron_id and --userid => SUCCESS: You can login in all cases 6) Try combining some or all the parameters => SUCCESS: It fails when it should, it succeeds when it should 7) Sign off :-D Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86932|0 |1 is obsolete| | Attachment #86933|0 |1 is obsolete| | Attachment #86934|0 |1 is obsolete| | --- Comment #22 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86937&action=ed… Bug 17746: Make koha-reset-passwd user set_password.pl Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #21 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86934&action=ed… Bug 17746: (QA follow-up) Make set_password.pl generate a password if required This patch makes the set_password.pl script generate the password if it is not passed as an argument. It also changes the behaviour of set_password.pl: it will now print the userid and password (generated or not) to mimick the behaviour from koha-reset-passwd. The koha-reset-passwd gets simplified as it doesn't generate the random password anymore, it passes the responsability to set_password.pl To test: - Follow the steps from the original platch - Verify all behaves as expected Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #20 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86933&action=ed… Bug 17746: Add misc/admin/set_password.pl script This patch introduces a script that allows changing a patron's password. The change overrides the defined password enforcement policy. If multiple conditions are passed to match on the patron, they all need to match. Otherwise an error message is printed. Attributes to search the patron on: - cardnumber - patron_id (a.k.a. borrowernumber) - userid we usually know some of them, but if we specify more than one, they need to match a patron, together. To test: 1) Apply this patch 2) Have a known patron (i.e. you know the cardnumber, the borrowernumber and the userid). 3) Run: $ kshell k$ perl misc/admin/set_password.pl --cardnumber <the_card_number> \ --password a_password 4) Verify you can login with the new password 5) Repeat 3) through 5) with --patron_id and --userid => SUCCESS: You can login in all cases 6) Try combining some or all the parameters => SUCCESS: It fails when it should, it succeeds when it should 7) Sign off :-D Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84798|0 |1 is obsolete| | Attachment #84899|0 |1 is obsolete| | Attachment #85363|0 |1 is obsolete| | --- Comment #19 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86932&action=ed… Bug 17746: Make koha-reset-passwd user set_password.pl Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '19

23 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 daveppub(a)asu.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daveppub(a)asu.edu -- You are receiving this mail because: You are watching all bug changes.

1 0