March 2019 - Koha-bugs - lists.koha-community.org

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86885&action=ed… Bug 12159: (QA follow-up) Remove double use module Speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86884&action=ed… Bug 12159: (QA follow-up) Rename relation in Patron::Attributes It seems that we do not need the extra belongs_to in the schema result files if we rename the relation to code. Test plan: Run t/db_dependent/Koha/Patrons.t Run t/db_dependent/Koha/Patron/Attributes.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86167|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86883&action=ed… Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86166|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86882&action=ed… Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> [EDIT] Removed Koha/Schema/Result/BorrowerAttribute.pm [EDIT] Added missing semicolon on L114 in Koha/Patron/Attribute.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Saw this warning once: Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc line 84. False warning from qa tools: Koha/Patron/Attribute.pm critic/forbidden patterns: forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 127) A dumb question: + return Koha::Patron::Attributes->search({ + borrowernumber => $self->borrowernumber, + branchcode => $self->branchcode, + }); => Is the branchcode needed? Koha/Patron/Attribute.pm L114 return $av->next->lib if $av->count Amended: adding a semicolon for future ease. Koha/Schema/Result/BorrowerAttribute.pm => Please do not add DBIx schema files in a regular patch. I removed it now. Btw it seems no longer necessary if we rename the relation in the Koha object. See follow-up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86168|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Comment on attachment 86168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86168 Bug 12159: (QA follow-up) Silencing POD warn from qa tools No longer needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85019|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86881&action=ed… Bug 13735: Update PrepareItemrecordDisplay to use maxlength The PrepareItemrecordDisplay method used to generate the item display on receiving serials was using a hardcoded maxlength of 255 on input fields. This patch updates it to use the maxlength defined in the frameworks instead as the normal item form does. To test: - Create or reuse an existing subscription - Make note of the framework the record uses - Add an item on receive - Check the maxlength on the various fields is set to 255 (check source code or use developer tools) - You can also verify that by adding a long note to one of the note fields - Apply patch - Repeat tests, the maxlength should now be 9999 - In your framework settings, change the length of one of the subfields to another value - Verify that the item form reflects the change Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0