April 2019 - Koha-bugs - lists.koha-community.org

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #137 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Nick Clemens from comment #132) > I like this one a lot - can we get a squashed/clean version of these patches > just for readability sake? Is this rebase OK for you Nick? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #136 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 89015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89015&action=ed… Bug 8995: (QA follow-up) Convert db update to perl Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #135 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 89014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89014&action=ed… Bug 8995: (follow-up) Add tests, move open_url/coins routines to Koha namespace Test plan: 1) Ensure the COinS span tag is still included on this pages. You need to look into html source and search for span tag with class 'Z3988', which has COinS string in title. Staff client: catalogue -> ISBDdetail catalogue -> MARCdetail catalogue -> detail virtualshelves -> shelves OPAC (you should have COinSinOPACResults system preference enabled): opac detail opac search opac shelves 2) Run tests: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Tested with all 9 current patches. Works as advertised, including OPACURLOpenInNewWindow. If a record has no items, no OpenURL link is displayed. All the suggested tests pass. I did not test with XSLT turned off. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #134 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 89013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89013&action=ed… Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88735|0 |1 is obsolete| | Attachment #88736|0 |1 is obsolete| | Attachment #88737|0 |1 is obsolete| | Attachment #88738|0 |1 is obsolete| | Attachment #88739|0 |1 is obsolete| | Attachment #88740|0 |1 is obsolete| | Attachment #88741|0 |1 is obsolete| | Attachment #88742|0 |1 is obsolete| | Attachment #88743|0 |1 is obsolete| | Attachment #88744|0 |1 is obsolete| | --- Comment #133 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 89012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89012&action=ed… Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11976] Add column settings + new column "Publication date" to the subscription table
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 [Bug 22803] Set dataTable width issue -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9557] Syndetics: Include EANs from MARC records in links on OPAC pages
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9557 --- Comment #3 from rkuiper(a)roundrocktexas.gov --- Katrin, I have checked about 40 items that don't have the cover image in the search results page and didn't find any that had a cover image on the details page. It used to be easy to find an example. Tentatively, I am saying we don't have the problem any more. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21026] New: Statistics tab in patron account should show descriptions instead of codes
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026 Bug ID: 21026 Summary: Statistics tab in patron account should show descriptions instead of codes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The statistics tab in the patron account shows codes instead of descriptions for - collection - location - item types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 9844] Add a barcode queue to checkout / return
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9844 --- Comment #4 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Katrin Fischer from comment #3) > This bug was filed 'pre-Plack' for staff interface and before the > performance improvements done since (2013). Is it still valid? I think it is still valid, although not as critical as before, sometimes a network lag or waiting to db lock when making backup could make circulation process a bit slower than it could be... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7916] Events module
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7916 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com, | |rbit(a)rbit.cz -- You are receiving this mail because: You are watching all bug changes.

1 0