April 2019 - Koha-bugs - lists.koha-community.org

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #75 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I guess I was too sleepy last night - the date field shows up once you actually click on a hold to renew. I think it might be debatable to show it with clicking the checkbox, but really no reason at all to fail this :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 30 Apr '19

30 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #74 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Andrew, it might be my messed up rebase (changes from 21757 caused a conflict), but now the hold due date never shows up. Test case: - Hold renewals allowed - Renewal limit overrides are not 2 items on my account, both are 'on hold' Check the checkbox - checkboxes unlock But: the date doesn't show up I am sorry, I'll give it another go tomorrow! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89034|0 |1 is obsolete| | --- Comment #73 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89052&action=ed… Bug 7088: (follow-up) Modify checkbox enabling As described in comment #50, we need to only enable renewal on items that are disabled in line with which sysprefs are enabled. So we now only enable renewal of on hold items if the AllowRenewalOnHoldOverride syspref is on and we only enable renewal of all other limited items when the AllowRenewalLimitOverride syspref is on. NOTE: The test plan below has changed substantially from previous iterations Test plan (you might want to make a coffee first...): - Apply patch - Rebuild CSS - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - The patron also needs to have an item on loan that cannot be renewed for some other reason, say renewal limit has been reached => TEST: Observe that it is NOT possible to select either item for renewal - Enable the "AllowRenewalLimitOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, but not the item that is on hold - Disable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it is NOT possible to select the the item that has reached the renewal limit, but it IS possible to select the item on hold - Enable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, AND it IS possible to select the item on hold - Select the item that is on hold => TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item => TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" => TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" => TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" => TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" => TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit => TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" => TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89033|0 |1 is obsolete| | --- Comment #72 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89051&action=ed… Bug 7088: (follow-up) AllowRenewalLimitOverride fix This patch causes the click event listener on the #override_limit to be created if EITHER the AllowRenewalOnHoldOverride OR AllowRenewalLimitOverride sysprefs are enabled. Previously, it would only be created if the AllowRenewalLimitOverride syspref was enabled, which would cause the checkbox to be displayed but do nothing. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89032|0 |1 is obsolete| | --- Comment #71 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89050&action=ed… Bug 7088: (follow-up) Add pref to checkbox As per commit #29 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c29 Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89031|0 |1 is obsolete| | --- Comment #70 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89049&action=ed… Bug 7088: (follow-up) Default hold checkbox display As per item 4 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Now, the checkbox for renewing on hold items behaves the same way as the checkbox for renewing items that have reached their renew limit. It is necessary to check the re-labelled "Override renewal restrictions" checkbox before it is possible to select on-hold items for renewal. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89030|0 |1 is obsolete| | --- Comment #69 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89048&action=ed… Bug 7088: (follow-up) Set syspref default to off As per item 2 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89029|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89047&action=ed… Bug 7088: (follow-up) Remove script "type" attribute As per item 1 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0