April 2019 - Koha-bugs - lists.koha-community.org

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #175 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88879&action=ed… Bug 8000: (QA follow-up) Two lastminute fixes [1] Number of tests Letters.t [2] Resolving uninitialized warn on Letters, L1327 Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86865|0 |1 is obsolete| | --- Comment #174 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88878&action=ed… Bug 8000: (QA follow-up) Add email validation to system preferences This patch uses the JQuery validator plugin to add validation to preferences of class email in the system preferences page. A field containing an invalid value (even if not modified) should prevent saving. To test, confirm that when entering an invalid email address in the SendAllEmailsTo field, an error message appears and saving is prevented. Correcting the value should hide the message and let you save as normal. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86864|0 |1 is obsolete| | --- Comment #173 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88877&action=ed… Bug 8000: (QA follow-up) Update the to_address in the message queue Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86863|0 |1 is obsolete| | --- Comment #172 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88876&action=ed… Bug 8000: (QA follow-up) Fix accidently edited sysprefs.sql file Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86862|0 |1 is obsolete| | --- Comment #171 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88875&action=ed… Bug 8000: (QA follow-up) Centralise Bcc too Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86861|0 |1 is obsolete| | --- Comment #170 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88874&action=ed… Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #51 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88868&action=ed… Bug 7088: (follow-up) Modify checkbox enabling As described in comment #50, we need to only enable renewal on items that are disabled in line with which sysprefs are enabled. So we now only enable renewal of on hold items if the AllowRenewalOnHoldOverride syspref is on and we only enable renewal of all other limited items when the AllowRenewalLimitOverride syspref is on. NOTE: The test plan below has changed substantially from previous iterations Test plan (you might want to make a coffee first...): - Apply patch - Rebuild CSS - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - The patron also needs to have an item on loan that cannot be renewed for some other reason, say renewal limit has been reached => TEST: Observe that it is NOT possible to select either item for renewal - Enable the "AllowRenewalLimitOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, but not the item that is on hold - Disable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it is NOT possible to select the the item that has reached the renewal limit, but it IS possible to select the item on hold - Enable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page - Check the "Override renewal restrictions" checkbox => TEST: Observe that it IS possible to select the the item that has reached the renewal limit, AND it IS possible to select the item on hold - Select the item that is on hold => TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item => TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" => TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" => TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" => TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" => TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit => TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" => TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0