April 2019 - Koha-bugs - lists.koha-community.org

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #50 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Katrin Fischer from comment #49) > Hi Andrew, > > I am very sorry, not sure the last patch is quite right. I think what > happens now is that either will make 'all' checkboxes appear, if the item is > on hold or not. I think we need to control the checkboxes separately, if > that makes sense? > > Test case: > Have at least 2 items checked out, 1 is on hold. > > AllowRenewalOnHoldOverride Allow > AllowRenewalLimitOverride Don't allow > > - Restriction override checkbox below table appears - OK > - Checking the box, enables the on hold item for renewal - OK > - Checking the box also enabled all other items for renewal - not OK -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #169 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13342] Not logged in user can place a review/comment as a deleted patron
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko(a)abunchofthings.net Keywords|Academy |dependency -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #66 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- @RM: Do we still have a keyword for packaging? dependency? Net::CIDR is added, but it seems to be installed already with koha-common and friends. The pref allows both start-finish and CIDR IP ranges. Although formally piping the pref into range2cidr converts start-finish ranges into CIDR. Both work. The patch uses CGI header(status=> ...) notation. The codebase also contains the older -status notation. But CGI::Util handles both. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86123|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88866&action=ed… Bug 14407: Follow up to add test case and clean noise Comment #28 has a /36 which is invalid CIDR. This triggers a crash and noise. This cleans up the crash and noise, and adds test cases to check for them. prove t/Auth.t -- before missing null case, and /36 case. -- after null case, and /36 with/without warnings. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80737|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88865&action=ed… Bug 14407: Follow up add missing atomic update The patch only added the system preference for fresh installs. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80736|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88864&action=ed… Bug 14407: Unit tests for in_ipset TEST PLAN --------- 1) apply all pathches 2) sudo koha-shell -c bash kohadev prove t/Auth.t -- should run. 3) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80735|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 88863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88863&action=ed… Bug 14407: Allow restricting SCO to IP or IP range Converted this to actual applicable patches. I think the test plan is comment #28. -- Mark Tompsett Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0