April 2019 - Koha-bugs - lists.koha-community.org

[Bug 6759] Use a different account type for account renewals than for new accounts
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6759] Use a different account type for account renewals than for new accounts
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 --- Comment #4 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88615&action=ed… Bug 6759: Update existing accountlines for 'A' Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6759] Use a different account type for account renewals than for new accounts
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 --- Comment #3 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88614&action=ed… Bug 6759: Split account creation and renewal charges Test plan: 1. Enable charging for patron enrolement 2. Add a new patron where the category is charged for 3. Note the charge of type 'Account management fee' 4. Renew the patron 5. Note the next charge of type 'Account management fee' 6. Apply patch 7. Repeat steps 1-6 and note the first charge will be of type 'Account creation fee' and the second of type 'Account renewal fee' 8. Bonus points, enable 'FeeOnChangePatronCategory' and check that when changing a patron from a free category to a charged one that a new 'Account renewal fee' is charged. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88059|0 |1 is obsolete| | --- Comment #17 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88613&action=ed… Bug 15260: (follow-up) Fix misnamed variable This was causing the amount to push by to be incorrectly calculated Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88057|0 |1 is obsolete| | --- Comment #16 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88612&action=ed… Bug 15260: Fix calculation of add amount In a sequence of closed days, we should take into account the nature of each closed day as we encounter it in order to calculate the amount to add to reach the next potential closed date. We are now doing this. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88056|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88611&action=ed… Bug 15260: Add unit tests This patch adds unit tests of the CalcDueDate function to ensure that the useDaysMode "Dayweek" mode works as expected Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88055|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88610&action=ed… Bug 15260: Implement weekly rollforward This patch will, when appropriate, roll due dates forward by full weeks, rather than single days. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88054|0 |1 is obsolete| | --- Comment #13 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88609&action=ed… Bug 15260: Modify next/prev_open_day We require next_open_day & prev_open_day to be more flexible. We could create a separate sub, but that's not very DRY given that they'll do pretty much the same thing. So next_open_day becomes next_open_days and prev_open_day becomes prev_open_days and both functions accept an additional parameter which determines how many days they add or subtract. All calls of these two functions have been modified accordingly. Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88053|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88608&action=ed… Bug 15260: Modify description of Dayweek option Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88052|0 |1 is obsolete| | --- Comment #11 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 88607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88607&action=ed… Bug 15260: Add new useDaysMode option "Dayweek" This patch adds a new "Dayweek" option to the useDaysMode syspref, it has the description: "the calendar to push the due date to the next open day on the same weekday". Sponsored-by: Cheshire West and Chester and Cheshire East Councils Sponsored-by: Newcastle City Council Sponsored-by: Sefton Council -- You are receiving this mail because: You are watching all bug changes.

1 0