April 2019 - Koha-bugs - lists.koha-community.org

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #44 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88606&action=ed… Bug 11573: (follow-up) Correction to accountype search on opac-user.pl With the update of accountype from 'Rent' to four distinct accountypes we need to update the search here to catch all four types of charge. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88602|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88605&action=ed… Bug 11573: Update of unit tests This patch updates the unit tests to reflect the changes to the core routines. The relevant changes are the removal of a hard coded 'description' and the splitting up of the 'Rent' accounttype into 'RENT', 'RENT_RENEW', 'RENT_DAILY' and 'RENT_DAILY_RENEW'. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88601|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88604&action=ed… Bug 11573: Update existing accountlines for 'Rent' Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88600|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88603&action=ed… Bug 11573: Make rental accountlines translatable To test: 1. Set up an item type with a rental charge 2. Issue an item with that item type 3. Check fines, a charge of type 'Rent' will be visible with a description of 'Rental'. 4. Renew the item 5. Check fines, a charge of type 'Rent' will be visible with a description of 'Renewal of Rental Item TITLE BARCODE' where TITLE and BARCODE are the items title and barcode. 5. Apply the patch 6. Repeat steps 1-4, charge descriptions should now be empty and charge types should display 'Rental fee' and 'Renewal of rental item'. 7. Repeat steps 1-6 for an item type with a daily rental charge and note the charge types are now 'Daily rental fee' and 'Renewal of daily rental item' Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #40 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- All ready to go now :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #39 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88602&action=ed… Bug 11573: Update of unit tests This patch updates the unit tests to reflect the changes to the core routines. The relevant changes are the removal of a hard coded 'description' and the splitting up of the 'Rent' accounttype into 'RENT', 'RENT_RENEW', 'RENT_DAILY' and 'RENT_DAILY_RENEW'. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #38 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88601&action=ed… Bug 11573: Update existing accountlines for 'Rent' Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88549|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88600&action=ed… Bug 11573: Make rental accountlines translatable To test: 1. Set up an item type with a rental charge 2. Issue an item with that item type 3. Check fines - the rental charge does not show the title of the issued item 4. Renew that item, the renewal charge does show the title of the issued item 5. Apply the patch 6. Repeat steps 1-4, both should show the title of the issued item in the description. 7. Repeat steps 1-6 for an item type with a daily rental charge Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '19

24 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes.

1 0