April 2019 - Koha-bugs - lists.koha-community.org

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87150|0 |1 is obsolete| | --- Comment #136 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88457&action=ed… Bug 14576: (follow-up) Using item objects, not hashrefs Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87149|0 |1 is obsolete| | --- Comment #135 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88456&action=ed… Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find Test plan: 1) Apply all patches except this one 2) Checkout out an item to a patron 3) Check the item in - note that this will fail 4) Apply this patch, and repeat steps 1-3, noting instead that the the check is instead successful 5) Verify also that reserves act as expected 5) Sign off Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87148|0 |1 is obsolete| | --- Comment #134 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88455&action=ed… Bug 14576: Rebase fixes Fix test Rebase code Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87147|0 |1 is obsolete| | --- Comment #133 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88454&action=ed… Bug 14576: (follow-up) fix some typos and style Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87146|0 |1 is obsolete| | --- Comment #132 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88453&action=ed… Bug 14576: Update to use get_yaml_pref_hash Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87145|0 |1 is obsolete| | --- Comment #131 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88452&action=ed… Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87144|0 |1 is obsolete| | --- Comment #130 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88451&action=ed… Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22756] New: Table suggestions lacks foreign key constraints
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22756 Bug ID: 22756 Summary: Table suggestions lacks foreign key constraints Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: Windows Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: vasanth.k(a)infoplus.co.in QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 22250] New: Clean up Mana KB integration with serials and reports
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Bug ID: 22250 Summary: Clean up Mana KB integration with serials and reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: koha-bugs(a)lists.koha-community.org, testopia(a)bugs.koha-community.org Depends on: 17047, 22237 Target Milestone: --- There are a number of template and JavaScript improvements I'd like to make to the files related to Mana integration with serials and reports: markup corrections, improved error handling, and general UI improvements. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 [Bug 22237] Subscriptions are not linked to Mana upon edit -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

1 17

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '19

23 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #48 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Hi Katrin Now I've added that patch, the checkbox will be displayed and be functional if the user has "circulate_override_renewals" and EITHER "AllowRenewalLimitOverride" OR "AllowRenewalOnHoldOverride" are enabled. Consequently, the test plan is now slightly incorrect, revised version below: - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it is NOT possible to select this item - ** Carry out all following steps, first with the "AllowRenewalLimitOverride" syspref enabled, then with the "AllowRenewalOnHoldOverride" syspref enabled ** - Return to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - Check the "Override renewal restrictions" checkbox - TEST: Observe that it IS possible to select this item - Select the item - TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item - TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" - TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" - TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" - TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" - TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit - TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" - TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified -- You are receiving this mail because: You are watching all bug changes.

1 0