May 2019 - Koha-bugs - lists.koha-community.org

[Bug 22169] New: ill-requests.tt failing QA test
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22169 Bug ID: 22169 Summary: ill-requests.tt failing QA test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Target Milestone: --- The id and class attributes on the body tag are causing: not ok 2 - <body> tag with id and class attributes # Failed test '<body> tag with id and class attributes' # at xt/tt_valid.t line 91. # Files list: # intranet-tmpl/prog/en/modules/members/ill-requests.tt: 16 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 21900] New: intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 Bug ID: 21900 Summary: intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Commit 1a0172a253e5432e5eef862768aaacb3463501f2 broke the display of buttons provided by plugins making use of the intranet_catalog_biblio_enhancements_toolbar_button hook. The addition of the html filter breaks the ability of the browser to parse the HTML provided by the plugin, the $raw filter needs to be used instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 21679] New: Software error when placing a hold on an item with a charge associated with it
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21679 Bug ID: 21679 Summary: Software error when placing a hold on an item with a charge associated with it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you try and place a hold on an item with a charge associated with it, the hold fails with the error: Undefined subroutine &C4::Reserves::getnextacctno called at /usr/share/koha/C4/Reserves.pm line 574. The getnextacctno function is in C4::Accounts. This is exactly the same issue as bug 21641 and should be resolved in the same way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 20923] New: Merging backend status graph into main status graph incorrect use of grep
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923 Bug ID: 20923 Summary: Merging backend status graph into main status graph incorrect use of grep Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com When the Illrequest object is being constructed, it consults the status graphs for enabled backends. These status graphs are then merged into the main graph in order to provide the full workflow for a request. As part of this process, the "next_actions" property is updated to reflect any new statuses. During this, a check is performed to determine if the status graph knows about the next status being declared by a backend status graph: if ( grep $prev_action, @core_status_ids ) { This is incorrect. According to http://perldoc.perl.org/functions/grep.html, the first parameter should be a block or expression, here we are passing a string. This malfunctions in so much as passing "REQ" with match twice in the following array [ "REQ", "REQREV" ], this is not what we would expect. The fix is to substitute the following line: if ( grep /^$prev_action$/, @core_status_ids ) { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 20917] New: Improve email functionality relating to ILL requests
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 Bug ID: 20917 Summary: Improve email functionality relating to ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com The ILL module has the ability to send emails containing details of requests to "partner" libraries. This functionality, though currently in the core ILL code, is actually only required by the "FreeForm" backend. It is surfaced in the UI as a form containing an email template and a multi-select to select the partners who will receive the email. The email functionality offered by ILL, though functional, is lacking in some important respects, which this bug proposes addressing. Proposed enhancements, which are all inter-related, are: - Move emailing functionality from the core ILL module to the FreeForm backend where it is actually used - Email is sent independently of the Koha message queue, which is understood to be undesirable, this should be addressed - As such, there is no ability for users to specify a default message template, using the Notices and Slips module, this should be addressed - It is not possible for users to specify default "reply-to" addresses for all ILL related emails, currently the ReplyToDefault syspref is used, this should be addressed - No message notification is sent to nominated staff when a request is modified, this should be addressed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 20883] New: Patron userid should be exposed
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 Bug ID: 20883 Summary: Patron userid should be exposed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Currently, when displaying a list of ILL requests, or viewing a single request, the requester's userid is not displayed. This should be visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 21016] New: Plugins: Expand usage of opac_js method, or create intranet_js
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21016 Bug ID: 21016 Summary: Plugins: Expand usage of opac_js method, or create intranet_js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org There is an opac_js method which gives the opportunity for a plugin to return some Javascript to be embedded in the OPAC. I propose that we either make this method more generic, perhaps, plugin_js, so it can reasonably be used for JS for either the OPAC or intranet, or we add an intranet_js method for embedding JS in plugins that touch the staff client. I suspect there's a use case for a plugin wanting to return different JS for the OPAC and staff client, so the latter idea might be preferable. The inspiration for this proposal is the CLA Check Permissions plugin (Bug 20968), the current workflow is a bit clunky with the button on the Bib toolbar taking the user to a page generated by the plugin, on which the main Javascript is run, opening a modal. The plugin has no use for the additional page, but is necessary to run the Javascript. The proposal would allow us to run the Javascript directly in the Bib view, which would make for a better UX. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 20646] New: "ILL Request" menu options not displayed when user has superlibrarian permission
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646 Bug ID: 20646 Summary: "ILL Request" menu options not displayed when user has superlibrarian permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com CC: andrew.isherwood(a)ptfs-europe.com, jonathan.druart(a)bugs.koha-community.org, katrin.fischer(a)bsz-bw.de, martin.renvoize(a)ptfs-europe.com Depends on: 7317, 20515 If the user has 'superlibrarian' permission, the menu is missing :( Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 18588] New: Integrate ILL generic_emails in notices system.
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18588 Bug ID: 18588 Summary: Integrate ILL generic_emails in notices system. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: alex.sassmannshausen(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently ILLModule provides a hard-coded (English) email template to request ILLs from 'Partner' Libraries. This template should use the existing notices system to allow the template to be customized and translated. Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 21678] New: Adding debit "Renewal of Rental Item" does not create account_offset
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21678 Bug ID: 21678 Summary: Adding debit "Renewal of Rental Item" does not create account_offset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 33