May 2019 - Koha-bugs - lists.koha-community.org

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #7 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 89928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89928&action=ed… Bug 15221 - SIP server always sets the alert flag when item not returned The checked in response from the ACS always has the alert bit set to true, even when using the checked_in_ok option. This patch sets the alert bit to 0 when checked_in_ok is used and the item is checked in without a preceding checkout. To test: 0) Create patron in web interface with a cardnumber and userid of "staff" with a password that matches the account in SIPconfig.xml. Also set their branch to CPL (also matching SIPconfig.xml). 1) Create an item with a barcode of 'test' 2) Choose a patron to check out to and record their borrowernumber In one terminal: 3) cd to your git directory (e.g. /home/koha/koha) 4) perl ./C4/SIP/SIPServer.pm ~/koha-dev/etc/SIPconfig.xml In another terminal: 5) cd to your git directory (e.g. /home/koha/koha) 6) perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> NOTE: You need to replace <borrowernumber> with the borrowernumber from Step 2, and <password> with the password from Step 0. Before patch: koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|COStaff1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 00310320190521 003103APCPL|AOCPL|ABtest|AC<password>|BIN| READ: 101YNY20190521 003106AOCPL|ABtest|AQCPL|AJTest| After patch: koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|CO<password>|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 01000020190521 010000APCPL|AOCPL|ABtest|AC<password>|BIN| READ: 101YNN20190521 010004AOCPL|ABtest|AQCPL|AJTest| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP server always sets the |SIP server always sets the |alert flag |alert flag when item not | |returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #6 from David Cook <dcook(a)prosentient.com.au> --- According to http://multimedia.3m.com/mws/media/355361O/sip2-protocol.pdf, it seems like it's up to the ACS to decide when to raise an alert... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #5 from David Cook <dcook(a)prosentient.com.au> --- Is it just me or does there appear to be next to no extant documentation on SIP2 extensions? The best I can find is: https://help.oclc.org/Library_Management/WorldShare_Circulation/Release_not… https://sourceforge.net/p/jsip2/wiki/Home/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #4 from David Cook <dcook(a)prosentient.com.au> --- Still looking but I'm guessing that these are the problematic lines: my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, undef, $return_date); $self->alert(!$return); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 20 May '19

20 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #19 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Hi :), I tried to test https://github.com/pianohacker/koha => branch bz15522-withdeps As it is, before trying to rebase it on master. But I can't successfully load a demo dump and do an upgrade database successfully. The last tag on the branch is v17.11.00 with means that it was from master during v18.05 development So perldeps for 18.05 dumps tried: - MARC 21 latest (v3.1900003) http://git.koha-community.org/gitweb/?p=contrib/global.git;a=history;f=sand… I get these errors [1] with the atomic updates Other dumps tried http://git.koha-community.org/gitweb/?p=contrib/global.git;a=history;f=sand… - UNIMARC last 17.11.00 (this one should have worked) - UNIMARC last 17.05.00 - UNIMARC first 17.11.00 What did I miss to get a compatible state for the branch bz15522-withdeps ? [1] Upgrade to 17.12.00.020 done (Bug 20082 - Update descriptions of Vietnamese language) Upgrade to 17.12.00.021 done (Bug 19290 - Add system preference BrowseResultSelection) DEV atomic update: bug_15520-add_manage_circ_rules_restricted.sql DEV atomic update: bug_18887.perl DBD::mysql::db do failed: Can't create table `koha`.`circulation_rules` (errno: 150 "Foreign key constraint is incorrectly formed") [for Statement " CREATE TABLE `circulation_rules` ( `id` int(11) NOT NULL auto_increment, `branchcode` varchar(10) NULL default NULL, `categorycode` varchar(10) NULL default NULL, `itemtype` varchar(10) NULL default NULL, `rule_name` varchar(32) NOT NULL, `rule_value` varchar(32) NOT NULL, PRIMARY KEY (`id`), KEY `branchcode` (`branchcode`), KEY `categorycode` (`categorycode`), KEY `itemtype` (`itemtype`), KEY `rule_name` (`rule_name`), UNIQUE (`branchcode`,`categorycode`,`itemtype`,`rule_name`), FOREIGN KEY (branchcode) REFERENCES branches (branchcode) ON DELETE CASCADE ON UPDATE CASCADE, FOREIGN KEY (categorycode) REFERENCES categories (categorycode) ON DELETE CASCADE ON UPDATE CASCADE, FOREIGN KEY (itemtype) REFERENCES itemtypes (itemtype) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; "] at (eval 1177) line 4. DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) SELECT branchcode, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM branch_borrower_circ_rules "] at (eval 1177) line 24. DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) SELECT NULL, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM default_borrower_circ_rules "] at (eval 1177) line 29. DBD::mysql::db do failed: Can't DROP 'max_holds'; check that column/key exists [for Statement " ALTER TABLE branch_borrower_circ_rules DROP COLUMN max_holds "] at (eval 1177) line 34. DBD::mysql::db do failed: Can't DROP 'max_holds'; check that column/key exists [for Statement " ALTER TABLE default_borrower_circ_rules DROP COLUMN max_holds "] at (eval 1177) line 38. Upgrade to XXX done (Bug 18887 - Introduce new table 'circulation_rules', use for 'max_holds' rules) DEV atomic update: bug_18925.perl DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT categorycode, branchcode, NULL, 'patron_maxissueqty', COALESCE( maxissueqty, '' ) FROM branch_borrower_circ_rules "] at (eval 1178) line 4. DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT categorycode, branchcode, NULL, 'patron_maxonsiteissueqty', COALESCE( maxonsiteissueqty, '' ) FROM branch_borrower_circ_rules "] at (eval 1178) line 9. DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT categorycode, NULL, NULL, 'patron_maxissueqty', COALESCE( maxissueqty, '' ) FROM default_borrower_circ_rules "] at (eval 1178) line 18. DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT categorycode, NULL, NULL, 'patron_maxonsiteissueqty', COALESCE( maxonsiteissueqty, '' ) FROM default_borrower_circ_rules "] at (eval 1178) line 23. DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT NULL, NULL, NULL, 'patron_maxissueqty', COALESCE( maxissueqty, '' ) FROM default_circ_rules "] at (eval 1178) line 32. DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT NULL, NULL, NULL, 'patron_maxonsiteissueqty', COALESCE( maxonsiteissueqty, '' ) FROM default_circ_rules "] at (eval 1178) line 37. DBD::mysql::db do failed: Table 'koha.circulation_rules' doesn't exist [for Statement " INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) SELECT NULL, branchcode, NULL, 'patron_maxissueqty', COALESCE( maxissueqty, '' ) FROM default_branch_circ_rules "] at (eval 1178) line 46. [...] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6605] Store Patron Reading History separate from issues/old_issues
by bugzilla-daemon＠bugs.koha-community.org 20 May '19

20 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6605 Jon Knight <J.P.Knight(a)lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking cosponsors CC| |J.P.Knight(a)lboro.ac.uk -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4363] Support the patron internet resources field in Sip2
by bugzilla-daemon＠bugs.koha-community.org 20 May '19

20 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4363 Jon Knight <J.P.Knight(a)lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight(a)lboro.ac.uk --- Comment #3 from Jon Knight <J.P.Knight(a)lboro.ac.uk> --- Just wandering through old bugs with my bug wranglers hat on and noticed this one. A quick check of C4/SIP/ILS/Patron.pm doesn't show a PG flag in the C4::Members::patronflags being used to set anything in the %ilspatron structure. Is this something that is still required (considering the bug was filed 9 years ago)? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 20 May '19

20 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0