May 2019 - Koha-bugs - lists.koha-community.org

[Bug 14669] Search orders by managing library
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- Not sure if it's me or the patch, but when I try to apply, I get this message Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2671, in <module> do_apply(*args) File "/usr/local/bin/git-bz", line 1734, in do_apply attachmentdata=True) File "/usr/local/bin/git-bz", line 1472, in load bug._load(bug_reference.id, attachmentdata) File "/usr/local/bin/git-bz", line 1228, in _load response = self.server.send_request("GET", url) File "/usr/local/bin/git-bz", line 998, in send_request cookies = self.get_cookie_string() File "/usr/local/bin/git-bz", line 991, in get_cookie_string self.cookies = get_bugzilla_cookies(host) NameError: global name 'host' is not defined -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13094] Make it easy to hide 'Cancel all' button on holds over report
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Margaret <margaret(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret(a)bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22644] New: Some tests in Upload.t are not testing the right thing
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644 Bug ID: 22644 Summary: Some tests in Upload.t are not testing the right thing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17501 Target Milestone: --- Wondering if there is not something wrong or missing in t/db_dependent/Upload.t, the keep_file flag is not testing if the file is really kept. Also we are not testing if the files have been correctly created. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 [Bug 17501] Koha Objects for uploaded files -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 14576] Allow automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #78 from David Cook <dcook(a)prosentient.com.au> --- Actually, looking at "sub in_ipset" again, I'd also invert the logic, so that the default return value is 0. That way, if you've misconfigured the value of $ipset, you're not going to accidentally return 1. Also, using $ENV{'REMOTE_ADDR'} won't work properly if you're using a reverse proxy. I don't know how we handle this with Plack, but for CGI users running behind reverse proxies, there's no way this is going to work correctly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 22 May '19

22 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #77 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Martin Renvoize from comment #76) > We've not released yet.. perhaps we could change it to in_iprange quickly > before it's set in stone forever more. > > What do you think David, does that sound more appropriate? If folk are willing, I'd say yes to changing it. How about "in_ip_ranges"? If we look at the current "sub in_ipset", we see the following line: my @allowedipranges = split(' ', $ipset); Probably makes sense to use "ranges" or "range_list" since that's the terminology used by Net::CIDR as well: https://metacpan.org/pod/Net::CIDR#@cidr_list=Net::CIDR::range2cidr(@range_…; (Actually, if I really wanted to split hairs, I'd say "@allowedipranges" should probably be changed to "@ip_ranges", as theoretically this function could also be used to interrogate a list of IP ranges to block. Yay code re-use!) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16966] New: Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 Bug ID: 16966 Summary: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16961, 16965 Blocks: 16846 The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. The patches provided will refactor the code and fix these 2 issues. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961 [Bug 16961] Add the Koha::Objects->update method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 [Bug 16965] Add the Koha::Objects->search_related method -- You are receiving this mail because: You are watching all bug changes.

1 79

[Bug 14669] Search orders by managing library
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22184] New: Move payment note out of payments table and into payment form
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22184 Bug ID: 22184 Summary: Move payment note out of payments table and into payment form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- >From Comment 14 on Bug 21918: I got confused about the payment note feature. I am wondering, do we need it to be on the payments table? It seems a little confusing as you seem to only be able to save it actually paying a fine. Wouldn't it be enough if the field appeared editable on the actual form? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 19781] New: Make a xt test that checks all themes for missing includes, to avoid fallback
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19781 Bug ID: 19781 Summary: Make a xt test that checks all themes for missing includes, to avoid fallback Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org The fallback functionality of the themes is good, but it is resource intensive if something is really really missing from a theme. For example, a user might make a custom theme for their OPAC, specify a TT include, but not include it in their theme (intentionally, or accidentally). The process of looking through all of the themes to find the fallback causes very slow page loads for that page, we should have a test that theme creators can run to check for this circumstance. -- You are receiving this mail because: You are watching all bug changes.

1 1