May 2019 - Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #136 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #117) > - Are you sure we need the change to Koha::Object? Fixed in followup > - koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt > [% To.json(data) %] must have the html filter Fixed in followup > > - changes to opac-user.tt are wrong (not needed) Fixed in rebase. Please point out which lines you are referring to in the future. > - There are too many (unneeded) changes made to members/update-child.pl, it > will conflict with bug 20226 (not blocker) There are currently very few changes to this script. Maybe this was fixed in a previous rebase. > - misc/cronjobs/j2a.pl transaction must be done using > txn_begin/txn_commit/txn_rollback Fixed in followup > - C4::Installer::load_sql returned the following errors while attempting to > load /home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_14570.sql: > > I do not know what the error is. ? > - Charset/collate: > relationship VARCHAR(100) COLLATE utf8_unicode_ci NOT NULL, > => this is wrong > > - same in the atomic update Fixed in followup -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #135 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 89892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89892&action=ed… Bug 14570: Update schema files [Do Not Push] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #134 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 89891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89891&action=ed… Bug 14570: (QA Follow-up) Misc changes based on QA feedback -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89889|0 |1 is obsolete| | --- Comment #133 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 89890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89890&action=ed… Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine <kmpeine(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85411|0 |1 is obsolete| | Attachment #85412|0 |1 is obsolete| | Attachment #85431|0 |1 is obsolete| | --- Comment #132 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 89889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89889&action=ed… Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine <kmpeine(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_05_candidate | CC| |nick(a)bywatersolutions.com --- Comment #158 from Nick Clemens <nick(a)bywatersolutions.com> --- Excited about this, but too late for 19.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 --- Comment #34 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 89885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89885&action=ed… Bug 15260: (follow-up) Add missing POD As per comment #33 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 17 May '19

17 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22921] New: Relatives issues only shows first one
by bugzilla-daemon＠bugs.koha-community.org 16 May '19

16 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22921 Bug ID: 22921 Summary: Relatives issues only shows first one Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- In patron page, you may see issues of patrons linked by garantor. Actually the Ajax call on svc/checkouts fails to send several borrowernumbers, only first one is sent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5