May 2019 - Koha-bugs - lists.koha-community.org

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #45 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #42) > When approving a pending suggestion, nothing happens. In the logs there are > two errors: > > DBD::mysql::st execute failed: Cannot add or update a child row: a foreign > key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT > `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES > `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for > Statement "UPDATE `suggestions` SET `STATUS` = ?, `acceptedby` = ?, > `accepteddate` = ?, `branchcode` = ?, `managedby` = ?, `manageddate` = ? > WHERE ( `suggestionid` = ? )" with ParamValues: 0="ACCEPTED", 1="51", > 2='2019-05-14T15:34:15', 3="__ANY__", 4="51", 5='2019-05-14T15:34:15', > 6="3"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. See bug 22905, not related to this patchset. > No suggestions ASKED letter transported by email at > /home/vagrant/kohaclone/C4/Letters.pm line 608. Not sure what is that (need to do something?), but IIRC it already happened before this patchset as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10753] Don't use _ANY_ as branchcode when creating suggestions for 'Any library'
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22905 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Hum, maybe not related to this patchset actually. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Note the branchcode=__ANY__ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- When approving a pending suggestion, nothing happens. In the logs there are two errors: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `STATUS` = ?, `acceptedby` = ?, `accepteddate` = ?, `branchcode` = ?, `managedby` = ?, `manageddate` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0="ACCEPTED", 1="51", 2='2019-05-14T15:34:15', 3="__ANY__", 4="51", 5='2019-05-14T15:34:15', 6="3"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. No suggestions ASKED letter transported by email at /home/vagrant/kohaclone/C4/Letters.pm line 608. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19641] New: Move patron templates to the footer
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Bug ID: 19641 Summary: Move patron templates to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart(a)bugs.koha-community.org, nick(a)bywatersolutions.com, simon.pouchol(a)biblibre.com, testopia(a)bugs.koha-community.org Depends on: 19603, 19608 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for patron module templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 [Bug 19608] Move admin templates JavaScript to the footer: The rest -- You are receiving this mail because: You are watching all bug changes.

1 59

[Bug 22895] New: [18.11] cannot place item level holds
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22895 Bug ID: 22895 Summary: [18.11] cannot place item level holds Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- Backport of 22650 makes an object call to an item hashref retrieved by get item: 94 if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) { Should be $item->{itemnumber} -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 7890] Highlight required field in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86544|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 89734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89734&action=ed… Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 --- Comment #22 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Thanks a lot Katrin :D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20769] New: Duplicate fine generated when lost item is returned with BlockReturnOfLostItems activated
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20769 Bug ID: 20769 Summary: Duplicate fine generated when lost item is returned with BlockReturnOfLostItems activated Change sponsored?: --- Product: Koha Version: 17.11 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucy.vaux-harvey(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com User has an overdue item with a status of Longoverdue (Lost) which has been set from the DefaultLongOverdueLostValue DefaultLongOverdueDays preference. The maximum fine per loan has been accumulated (5 GBP). BlockReturnOfLostItems set to Block Item is checked in – check in is blocked as required however the Longoverdue (Lost) status is removed. Item can now be checked in again as it no longer has a Lost status and at this point a second max fine of 5 GBP is charged to the account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8