May 2019 - Koha-bugs - lists.koha-community.org

[Bug 21937] New: Syspref autoBarcode annual doesn't increment properly barcode in some cases
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21937 Bug ID: 21937 Summary: Syspref autoBarcode annual doesn't increment properly barcode in some cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When autoBarcode is set to 'annual', and there is an existing barcode beginning with the 4 digit of the current year, the auto generated barcode may be wrong. For example, you have this barcode '20184526546'. If you ask for the next 2018-000X barcode, you will 20184526547 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 11853] Cannot clear date of birth via OPAC patron update
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11853 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick(a)bywatersolutions.com --- Comment #10 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12627] SQLHelper replacement - C4::Suggestions
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907 [Bug 22907] Cannot add new suggestion with strict SQL modes turned on -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #28 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Josef Moravec from comment #27) > Could builder->build_object cover this case? I think you're right.. this can probably be closed as a duplicate at this point? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #45 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #42) > When approving a pending suggestion, nothing happens. In the logs there are > two errors: > > DBD::mysql::st execute failed: Cannot add or update a child row: a foreign > key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT > `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES > `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for > Statement "UPDATE `suggestions` SET `STATUS` = ?, `acceptedby` = ?, > `accepteddate` = ?, `branchcode` = ?, `managedby` = ?, `manageddate` = ? > WHERE ( `suggestionid` = ? )" with ParamValues: 0="ACCEPTED", 1="51", > 2='2019-05-14T15:34:15', 3="__ANY__", 4="51", 5='2019-05-14T15:34:15', > 6="3"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. See bug 22905, not related to this patchset. > No suggestions ASKED letter transported by email at > /home/vagrant/kohaclone/C4/Letters.pm line 608. Not sure what is that (need to do something?), but IIRC it already happened before this patchset as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10753] Don't use _ANY_ as branchcode when creating suggestions for 'Any library'
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22905 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Hum, maybe not related to this patchset actually. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Note the branchcode=__ANY__ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- When approving a pending suggestion, nothing happens. In the logs there are two errors: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_branchcode` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "UPDATE `suggestions` SET `STATUS` = ?, `acceptedby` = ?, `accepteddate` = ?, `branchcode` = ?, `managedby` = ?, `manageddate` = ? WHERE ( `suggestionid` = ? )" with ParamValues: 0="ACCEPTED", 1="51", 2='2019-05-14T15:34:15', 3="__ANY__", 4="51", 5='2019-05-14T15:34:15', 6="3"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. No suggestions ASKED letter transported by email at /home/vagrant/kohaclone/C4/Letters.pm line 608. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19641] New: Move patron templates to the footer
by bugzilla-daemon＠bugs.koha-community.org 14 May '19

14 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Bug ID: 19641 Summary: Move patron templates to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart(a)bugs.koha-community.org, nick(a)bywatersolutions.com, simon.pouchol(a)biblibre.com, testopia(a)bugs.koha-community.org Depends on: 19603, 19608 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for patron module templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 [Bug 19608] Move admin templates JavaScript to the footer: The rest -- You are receiving this mail because: You are watching all bug changes.

1 59