May 2019 - Koha-bugs - lists.koha-community.org

[Bug 22472] New: Should column_exists explode if the table does not exist?
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472 Bug ID: 22472 Summary: Should column_exists explode if the table does not exist? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- See bug 18936 comment 33. If C4::Installer::column_exists is called with a table that has been removed, the methods will print an error. I think it should early return if the table does not exist (not an exception, we do not want to make more complex the update DB script) -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #32 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 87531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87531 Bug 14723: Additional delivery notes to messages Review of attachment 87531: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=147…) ----------------------------------------------------------------- I took another look at the code and Joseph is right. Made some additional notes too. ::: C4/Letters.pm @@ +912,2 @@ > VALUES > +( ?, ?, ?, ?, ?, ?, ?, NOW(), ?, ?, ?, ? ) I think NOW() might be a MySQLism from my research. @@ +1281,5 @@ > # warn "FAIL: No 'to_address' and no email for " . ($member->{surname} ||'') . ", borrowernumber ($message->{borrowernumber})"; > # warning too verbose for this more common case? > _set_message_status( { message_id => $message->{'message_id'}, > + status => 'failed', > + delivery_note => 'Unable to find an email address for this borrower' } ); See above, these need to be dealt with in the template. ::: installer/data/mysql/atomicupdate/Bug-14723_-_Additional_delivery_notes_to_messages.perl @@ +1,3 @@ > +$DBversion = 'XXX'; # will be replaced by the RM > +if( CheckVersion( $DBversion ) ) { > + $dbh->do("ALTER TABLE message_queue ADD delivery_note TEXT"); Please use BEFORE or AFTER column to specify where the new column will be added exactly. This will help to keep things the same between new and old installations. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22763] New: Stuck on acquisition
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22763 Bug ID: 22763 Summary: Stuck on acquisition Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: shubham.gupta(a)srdt.co.in QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88599&action=ed… Stuck on acquisition Hi, As I am new user on koha and proceeding for vendor creation after setup of budget and funds I'm getting an error as attached below. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 8558] Better confirmation message for importing frameworks
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89491|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89588&action=ed… Bug 8558: (QA follow-up) a little more text clean up You can take or leave it, honestly, I just thought we could be a little more explicit about what we were overwriting. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8558] Better confirmation message for importing frameworks
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89489|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89587&action=ed… Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% frameworkcode %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8558] Better confirmation message for importing frameworks
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8558] Better confirmation message for importing frameworks
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I just realized that with the modal staying in the background this is already a bit better than it used to be, because you can see the framework code there as well :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11853] Cannot clear date of birth via OPAC patron update
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11853 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx a lot for the fix, this one was giving me a headache! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11853] Cannot clear date of birth via OPAC patron update
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11853 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89484|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89581&action=ed… Bug 11853: Add tests Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0