May 2019 - Koha-bugs - lists.koha-community.org

[Bug 14669] Search orders by managing library
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87477|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89619&action=ed… Bug 14669: Add search option for managing library to orders search Currently the order search can't be limited by managing library. The patch adds the search option to the order history search form and a column for the managing library to the search results table. To test: - Create some baskets with orders - Set managing library for some, but also have some without - Apply patch - prove t/db_dependent/Acquisition.t - Go to Aquisition > Orders search tab on top > Advanced search link - Search for orders without limiting Orders with and without managing library set should show up - Limit search to a specific managing library - Verify results match expectations -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14669] Search orders by managing library
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22069] New: Viewlog not displaying renewals correctly
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22069 Bug ID: 22069 Summary: Viewlog not displaying renewals correctly Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: barry.cannon(a)interleaf.ie QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- If Tools > Log Viewer is selected and run using the module "Circulation" with the action of "Renew" no results are shown. Selecting the action of "All" shows all results including renewals. The reason appears to be because when selecting the action of "Renew" the form POST uses the action parameter value of "RENEW". This, in turn, gets passed to GetLogs where is used in the SQL query. However, the actual value that is logged in the action_logs table is "RENEWAL" and not "RENEW". Changing the SQL query to "RENEWAL" obtains the correct results. RENEW is correct for the MEMBERS module but RENEWAL should be used for Circ. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 4833] Show acquisition information when ordering from suggestion
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4833] Show acquisition information when ordering from suggestion
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- A late night attempt - Nick, can you check please? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4833] Show acquisition information when ordering from suggestion
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89618&action=ed… Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion This patch adds the budgetname to the return of SearchSuggestion to improve performance. To test: - Same test plan as for the first patch - Verify fund names show in the table - Run t/db_dependent/Suggestions.t -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #158 from Michal Denar <black23(a)gmail.com> --- Hi Katrin, OK, one day after. It's sad for me. But I hope that we finish this bug soon. 19.11. will be fine. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #157 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Michal Denar from comment #156) > I really love this at 19.05. Aleisa, can you rebase it on master. I'm ready > for test. Hi Michal, we have reached 'feature freeze' - this means no new features will be pushed for 19.05 apart from a select few that the RM has marked with rel_19_05_candidate. See here: http://lists.koha-community.org/pipermail/koha-devel/2019-April/045179.html -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #156 from Michal Denar <black23(a)gmail.com> --- I really love this at 19.05. Aleisa, can you rebase it on master. I'm ready for test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #155 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Currently this patch set doesn't apply. Can you please rebase? It might make sense to wait a bit until after the 19.05 release as this will be for 19.11. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15516: Allow to reserve first available item from a group of titles Using index info to reconstruct a base tree... M C4/Reserves.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt M reserve/placerequest.pl M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging reserve/placerequest.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Reserves.pm Applying: Bug 15516: Holding first available item from x biblios only count 1 reserve Applying: Bug 15516: Update old_reserves (reserve_group_id) Applying: Bug 15516: Set reserve-group.pl to be executable Applying: Bug 15516: Reword 'reserve group' to 'hold group' Applying: Bug 15516: Fix translation issues Applying: Bug 15516: (follow-up) Fix kohastructure.sql Applying: Bug 15516: (follow-up) Fix reserve -> hold change Applying: Bug 15516: (follow-up) Fix modal for hold group error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt). error: could not build fake ancestor Patch failed at 0001 Bug 15516: (follow-up) Fix modal for hold group The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15516-follow-up-Fix-modal-for-hold-group-vopUHO.patch -- You are receiving this mail because: You are watching all bug changes.

1 0