May 2019 - Koha-bugs - lists.koha-community.org

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #36 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 89194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89194&action=ed… Bug 5770: (QA follow-up) Move system preference to appropriate section The new sysprefs wher in the general admin section. I believe they are better placed within the acquisitions area. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #35 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 89193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89193&action=ed… Bug 5770: (QA follow-up) Revert change to GetQueuedMessages Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #34 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 89192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89192&action=ed… Bug 5770: (QA follow-up) Allow feature to be disable This patch adds 'None' to the available options for the feature so it may be disabled entirely (and sets that as default) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89147|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 89191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89191&action=ed… Bug 5770: Notify for new suggestion - sample notices Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89146|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 89190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89190&action=ed… Bug 5770: Unit test Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89145|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 89189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89189&action=ed… Bug 5770: New system pref for new suggestion email Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89144|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 89188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89188&action=ed… Bug 5770: Email librarian when purchase suggestion made Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2776 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2776] emailPurchaseSuggestions system preference deprecated
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2776 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5770 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11529] Add subtitle, medium and part fields to biblio table
by bugzilla-daemon＠bugs.koha-community.org 01 May '19

01 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #187 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1) RELEASE NOTES - Removes the Koha to Keyword mappings - Might cause change in behaviour for people having mappign fields outside of 245bhnp or UNIMARC equivalents - Requires you to run misc/batchRebuildBiblioTables.pl to have 245bhnp displayed 2) Template Toolkit Stash I noticed some of the files use Stash. I haven't come across this so far. Can you explain? koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +[% USE Stash %] Details for <i>[% INCLUDE 'biblio-title.inc' biblio=Stash.stash() %]</i> This is a problem, because at the moment this is only used for debugging and not marked as required in the Dependencies. Adding dependency tag to the bug. 3) SplitKohaField I wonder if the use case warrants its own subroutine, it's only used in a few places and for splitting a pipe separeted string into an array: C4/Biblio.pm:sub SplitKohaField { svc/checkouts: subtitle => C4::Biblio::SplitKohaField($c->{'subtitle'}), svc/holds:use C4::Biblio qw(SplitKohaField); svc/holds: subtitle => C4::Biblio::SplitKohaField($biblio->subtitle()), 4) Template variables Right now the changes require a lot of new variables passed to the templates and some older SQL methods to be extended to SELECT additional fields. I wonder if instead of working with an INCLUDE working with a TT plugin taking the biblionumber and querying would hurt performance much. It would allow us to remove quite a bit of code I think. Also I guess in the future working with a Record object might make things easier? 5) misc/batchRebuildBiblioTables.pl I noticed that you removed the table locking. Is this safe? 6) Unrelated changes Small one: koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc And: t/db_dependent/Biblio.t - my $authorities_mod = Test::MockModule->new( 'C4::AuthoritiesMarc' ); + my $authorities_mod = Test::MockModule->new( 'C4::Heading' ); 7) Repeatable subfields np Testing with: 245abhnpnp Multiple np show as: The C programming language / Zusatz Number | Number2 Part | Part2 Actually this is a deeper rabbit hole... as we don't keep the sequence we might lose meaning here, but that would not have worked before. Maybe this would make things a little easier? http://template-toolkit.org/docs/manual/VMethods.html#method_split 8) Good news - Removal of permission complete - Removal of Koha to keywords feature complete - Removal of GetRecordValue and Biblio:subtitles complete -- You are receiving this mail because: You are watching all bug changes.

1 0