June 2019 - Koha-bugs - lists.koha-community.org

[Bug 13640] Holds To Pull List includes items unreserveable items
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '19

21 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 90872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90872&action=ed… Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed If a rule has not been defined for an itemtype or you submit a biblio level hold, you cannot filter on holdallowed<>0. Test plan: Test with a biblio level hold. Have two items; one item should be blocked with a policy. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13640] Holds To Pull List includes items unreserveable items
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '19

21 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90639|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 90871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90871&action=ed… Bug 13640: Do not display unreserveable items on the Holds to pull screen We should only display the items that meet the hold policies Test plan: It would be good to have a huge list of holds displayed on the "Holds to pull" and confirm that the display is now correct. One of the possible test plan has been let in a comment on the bug report: Bib Record A has 2 items: Item Record X (can be placed on hold) Item Record Y (cannot be placed on hold) If you place a bib-level hold on Bib Record A, both Item Record X and Item Record Y show up as available items in the Holds To Pull List. With this patch applied you must not see Y Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13640] Holds To Pull List includes items unreserveable items
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '19

21 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13640] Holds To Pull List includes items unreserveable items
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '19

21 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #14) > Signing off as in a testing it appears to work as expected.. > > I'd love to see this query moved into a module and unit tested really, but > this fix works for now in my opinion.. good luck QAers. It does not work, but I agree about the module thing ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13640] Holds To Pull List includes items unreserveable items
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '19

21 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- The where condition is wrong. It should also incorporate the case that default_branch_item_rules is NULL (for istance, no corresponding record found for a biblio level hold). Will add a follow-up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13640] Holds To Pull List includes items unreserveable items
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '19

21 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Fails on strict sql mode: DBD::mysql::st execute failed: 'koha_master.reserves.reserve_id' isn't in GROUP BY [for Statement [ ... etc ] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13640] Holds To Pull List includes items unreserveable items
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '19

21 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '19

20 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9834] Reverting a waiting hold should lead to the former hold type (item or biblio level)
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '19

20 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|additional_work_needed | --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Pushed followup to master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17148] New: Add floating toolbar for tabs on cataloging interface
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '19

20 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17148 Bug ID: 17148 Summary: Add floating toolbar for tabs on cataloging interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: marjorie.barry-vila(a)ccsr.qc.ca QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Created attachment 54573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54573&action=ed… add floating toolbar for tabs Hi, It would be nice if tabs are add in floating toolbar like buttons. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.

1 2