June 2019 - Koha-bugs - lists.koha-community.org

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #34 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Arthur Suzuki from comment #30) > I guess we could move on this bugs since anyone agreed that this solves at > least the hourly loan issue. > From what I understood following the discussion, there is a bigger issue > with the whole fine calculation rules but I'd say it's not in the same scope > and shall be documented in another bugzilla. Given this comment, and the tests actually testing the changes. I figured it needed to be signed off to move forward. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #33 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 90957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90957&action=ed… Bug 14293: Add more tests and fix floor/ceil Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #32 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 90956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90956&action=ed… Bug 14293: Add more tests and improve get_chargeable_units Not sure at all about this change, especially because it could modify CalcFine Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85407|0 |1 is obsolete| | Attachment #85408|0 |1 is obsolete| | Attachment #85788|0 |1 is obsolete| | --- Comment #31 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 90955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90955&action=ed… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: Nick Clemens <nick(a)quecheelibrary.org> Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 90953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90953&action=ed… Bug 5287: (QA follow-up) update deprecated button Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90700|0 |1 is obsolete| | Attachment #90701|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 90952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90952&action=ed… Bug 5287: Add floating toolbar to search results in OPAC This patch adds the "hc-sticky" JavaScript library to the OPAC and uses it to make the search results toolbar "stick" to the top of the page as the user scrolls down. This patch also moves search results pagination into the toolbar so that pagination links are available. Font Awesome icons are added to the pagination include to replace arrow HTML entities. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - Perform a catalog search in the OPAC which will return multiple pages of results. Confirm that the toolbar "sticks" and that all controls in the toolbar work correctly. - Test at various browser widths to confirm that it adapt well to various sizes. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 21588] New: Add "Collapse/Expand" options on subscription-detail page
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21588 Bug ID: 21588 Summary: Add "Collapse/Expand" options on subscription-detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Linked to bug 21467. With the new enhancement that allows partial receipt for subscription, orderlines re displayed with a summary line on /cgi-bin/koha/serials/subscription-detail.pl page. Would be useful to have a "Collapse all" / "Expand all" options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 5287] Add floating toolbar to search results in OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Jun '19

24 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Passed QA |Patch doesn't apply --- Comment #9 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Sorry Owen.. I think a tidying push of yours I recently pushed knocked this one out.. Setting to Patch doesn't apply as I think you're better placed to rebase it and keep the tidier code than I am. Thanks -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0