June 2019 - Koha-bugs - lists.koha-community.org

[Bug 14794] Searching patron by birthday returns no results if format incorrect
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |nick(a)bywatersolutions.com --- Comment #6 from Nick Clemens <nick(a)bywatersolutions.com> --- It seems the code no longer hangs, this just improves visiblity of tooltip -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14794] Searching patron by birthday returns no results if format incorrect
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Searching patron by |Searching patron by |birthday is slow / never |birthday returns no results |gives a result |if format incorrect CC| |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14794] Searching patron by birthday is slow / never gives a result
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 --- Comment #5 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 90424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90424&action=ed… Bug 14794: Display JS tooltip whenever dateofbirth is being searched This updates the code that adds a tooltip for the correct date format to display after the initial search To test: 1 - Do a patron search, choosing date of birth as the search field 2 - Note on choosing that field you get a tooltip defining the format 3 - Do a search 4 - Note tooltip is gone, but date fo birth is still selected as the field to search 5 - Apply patch, reload 6 - Note tooltip shows after initial search and until field is changed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14794] Searching patron by birthday is slow / never gives a result
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14794 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14601] Cardnumber should not be required for patron import
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19012 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 20671] New: Adding "surname" to instructions. import_borrowers.pl / import_borrowers.tt
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20671 Bug ID: 20671 Summary: Adding "surname" to instructions. import_borrowers.pl / import_borrowers.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: jesse(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It appears that surname is now a required field when importing a file with patron data. According to the instructions, however, only 'branchcode' and 'categorycode' are required. Latter should be amended if surname is now required as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 14601] Cardnumber should not be required for patron import
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23077 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 18377] New: Add Plack/PSGI file for dev install
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Bug ID: 18377 Summary: Add Plack/PSGI file for dev install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Koha lacks a proper Plack file for dev install. debian/templates/plack.psgi is for package install and misc/plack/koha.psgi seems a bit outdated (you need 2 plack servers running — 1 for opac and 1 for intranet — and the REST API is not enabled in it) I'll attach a new one, based on debian/templates/plack.psgi but suited for a dev install -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 16733] New: Adjust or make flexible some paths in debian scripts
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Bug ID: 16733 Summary: Adjust or make flexible some paths in debian scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 66

[Bug 18003] New: Should deletedborrowers.borrowernumber be a primary key?
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Bug ID: 18003 Summary: Should deletedborrowers.borrowernumber be a primary key? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17782 (Raised from bug 17782) DBIC needs a primary key to work correctly. We could be tempt to make borrowernumber a primary key, but a use case could bring thing. Indeed if a table is empty and the mysql (mariadb behaves identically) server restarted, the Auto Increment (AI) is reset. Problematic use case: 1. Install Koha 2. Create a patron (borrowers.borrowernumber = 1) 3. Delete it (deletedborrowers.borrowernumer = 1, and AI is set to 2 4. Restart mysql => borrowers is empty so AI is reset 5. Create a patron (borrowers.borrowernumber = 1) 6. Delete it => We will try to insert a new row with an existing borrowernumber (1) into the deletedborrowers table: BOOM Solution 1: Do not care about this problematic use case and prevent to delete the last patron. Solution 2: Add a AI primary key (id) to deletedborrowers => The 2 tables borrowers and deletedborrowers will differ, bugs will be expected Solution 3: Deal with that at code level: when a patron is created, guess the borrowernumber it will get and check if it does not already exist in the deletedborrowers table. If so, force it before inserting it Solution 4: Do not enforce this constraint at DB level but set the primary key to DBIC schema: Koha::Schema::Result::Deletedborrower: __PACKAGE__->set_primary_key("borrowernumber"); Problem: Koha::Database->new->schema->resultset('Deletedborrower')->find(42); will raise a warning "DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single" if 42 is duplicated, and the first matching row will be picked Another solution? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted -- You are receiving this mail because: You are watching all bug changes.

1 19