June 2019 - Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre <nadine.pierre(a)InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88367|0 |1 is obsolete| | --- Comment #84 from Nadine Pierre <nadine.pierre(a)InLibro.com> --- Created attachment 90392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90392&action=ed… Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre <nadine.pierre(a)InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88366|0 |1 is obsolete| | --- Comment #83 from Nadine Pierre <nadine.pierre(a)InLibro.com> --- Created attachment 90391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90391&action=ed… Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre <nadine.pierre(a)InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88365|0 |1 is obsolete| | --- Comment #82 from Nadine Pierre <nadine.pierre(a)InLibro.com> --- Created attachment 90390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90390&action=ed… Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Nadine Pierre <nadine.pierre(a)InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88364|0 |1 is obsolete| | --- Comment #81 from Nadine Pierre <nadine.pierre(a)InLibro.com> --- Created attachment 90389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90389&action=ed… Bug 12446: Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10199] Move fields type, options and explanation from systempreferences table?
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com, | |oleonard(a)myacpl.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22575] New: Item type administration uses invalid error class for dialog
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Bug ID: 22575 Summary: Item type administration uses invalid error class for dialog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- If you try to delete an item type which is in use, the error message you get is displayed in a white dialog with red text. This happens because the message "type" passed from the script is "error," a CSS class which is undefined. The script should send "alert" instead. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 22444] New: currencies_manage permission doesn't provide link to manage currencies when selected alone
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Bug ID: 22444 Summary: currencies_manage permission doesn't provide link to manage currencies when selected alone Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Bug 7651 added the permission currencies_manage within the acquisitions permission subgroup. Giving a borrower just this permission and catalogue does make them technically able to load /currency.pl, but it doesn't provide them any link to get there. To Test: - create a patron - give them currencies_manage and catalogue permissions - log in as this patron - observe that there is no Currencies link out of Acquisitions and Administration doesn't appear on the home page or the More menu - give the patron any other admin permission - observe that the Currencies link now shows in Acquisitions - take away admin permissions and give the patron full acquisitions permissions - observe that a link to Currencies still appears in Acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 21089] New: Bad floats in Ordering information on acqui/supplier.pl
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089 Bug ID: 21089 Summary: Bad floats in Ordering information on acqui/supplier.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org I haven’t checked master yet, but in the 17.xx versions, I’m noticing it is really difficult to click the dropdown for “List prices are:” in “Ordering information” on /cgi-bin/koha/acqui/supplier.pl. When I look using the F12 tools in Chrome, I see that later “ol” elements are overlapping earlier “li” elements. So the “ol” for the tax options is sitting on top of the “li” for “List prices are:”. Only a tiny part of the “li” is clickable underneath that “ol”. It looks like the floats in the “li” element are causing the sizing of the “ol” to be no good. See https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_con…. There are a number of strategies for fixing this but I’m not sure what the best one would be here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 22560] New: Forgotten password "token expired" page still shows boxes to reset password
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Bug ID: 22560 Summary: Forgotten password "token expired" page still shows boxes to reset password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: wizzyrea(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- To replicate: Create a user with a username, password, and email defined Attempt to do a forgotten password recovery Munge your token link in whatever way you like (?uniqueKey=$2a$08$B9szbC5lwJd.mh.QznRHZu for example - this one should be invalid in your DB) Note that a yellow "This link is expired" box is shown, but the two password boxes are still there. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 18011] New: Categories.pl allows users to set the enrolementperioddate to before the current date without any error /warning messages
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Bug ID: 18011 Summary: Categories.pl allows users to set the enrolementperioddate to before the current date without any error/warning messages Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P3 Component: System Administration Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com At present when creating a patron category the user can select a date from the date picker which is earlier than the current date, meaning patrons created from the patron category have a dateexpire before they were even created. The fix of this bug is to implement a javascript message informing the user that the date they selected from the datepicker is invalid and forcing them to choose a new date before they can submit the form. -- You are receiving this mail because: You are watching all bug changes.

1 16