July 2019 - Koha-bugs - lists.koha-community.org

[Bug 23083] New: Course reserve item edit fails if one does not set all values
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23083 Bug ID: 23083 Summary: Course reserve item edit fails if one does not set all values Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- To Test: 1: Create an item with itype, ccode, location, and holding branch set 2: Create a course 3: Add item to course, changing the values for itype, ccode, and location 4: Click Edit for that item on course-details.pl 5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED 6: Hit Save 7: Back on course-details.pl, observe that the item is still showing the values set in step 3 8: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently 9: hit save 10: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Andrew <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew(a)bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91198|0 |1 is obsolete| | --- Comment #93 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 91823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91823&action=ed… Bug 1985: (follow-up) Fix Reviews.t logic Read the tests to make sure they make sense. Before the patch is applied, they don't. $nb_of_approved_reviews + 2 did not make sense, because the three reviews added were not approved. search->count counts everything, so the use of approved+3 didn't make sense. Rather than duplicate the search->count test, changed the first one to reflect that the added reviews were all unapproved. Before applying patch, prove fails. After applying patch, prove passes. Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91197|0 |1 is obsolete| | --- Comment #92 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 91822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91822&action=ed… Bug 1985: (follow-up) fix staff URL in other letters Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91196|0 |1 is obsolete| | --- Comment #91 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 91821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91821&action=ed… Bug 1985: (follow-up) Add letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Left signed off, even though uk-UA was rebased. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91195|0 |1 is obsolete| | --- Comment #90 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 91820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91820&action=ed… Bug 1985: (follow-up) correct http:// in staff URL Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91194|0 |1 is obsolete| | --- Comment #89 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 91819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91819&action=ed… Bug 1985: Send email alert when comment posted. Many blog systems have a feature where the admin gets an email when someone posts a new comment that needs to be moderated. It would be nice to incorporate this into Koha. Ideally, you could set an email address in system preferences where notifications should be sent (since the Koha administrator is probably not the one approving comments). The body of the email would contain the comments, and offer a direct link to approve or delete the comment. The authorship was corrected to Olli-Antti Kivilahti. In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91193|0 |1 is obsolete| | --- Comment #88 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 91818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91818&action=ed… Bug 1985: Fix whitespace in opac/opac-review.pl $ git diff -w origin/master -- should have no differences Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #73 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 26 Jul '19

26 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

1 0