July 2019 - Koha-bugs - lists.koha-community.org

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91725|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 --- Comment #7 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 91725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91725&action=ed… Bug 12949: (follow-up) Disable syspref by default Implemented fixes based on test feedback: * Set the GuarantorsMustBeLinkedToPatronAccount syspref to 0 (disabled) by default * When syspref is enabled and a guarantee is updated to an 'Adult' their borrowers.guarantorid, borrowers.contactname, borrowers.contactfirstname, borrowers.relationship are reset to NULL. Updated test plan: 1. Create an adult patron (make sure to set a first and last name) and select 'Add child' and save the child record 2. Run the following database query, and notice there are values for guarantorid, contactname, contactfirstname, relationship: SELECT guarantorid, contactname, contactfirstname, relationship FROM borrowers WHERE borrowernumber=<childsborrowernumber>; 3. On the child record select More > Update child to adult patron. 4. Select a new adult patron category and save 5. Notice guarantor information is still displayed on the new adults record 6. Repeat step 2 and notice guarantorid is empty/NULL and contactname and contactfirstname, relationship are unchanged 7. Now create a child record with an unlinked guarantor: In the patron home page select 'New patron'. Note: Make sure the patron category you select is of category type 'Child' 8. In the guarantor area of the patron creation page input a firstname and surname and don't select 'Set to patron' and save/submit the page 9. Repeat step 2 making the borrowernumber you enter the borrowernumber of the patron you made in step 8 and notice guarantorid is empty and contactname and contactfirstname are not empty. i.e. our guarantor is not linked to a Koha patron 10. Notice guarantor information is shown on the patron summary page of our user 11. Repeat step 3,4,5 and notice guarantor information is still displayed 12. Apply patch 13. Navigate to installer/data/mysql directory Enter the Koha shell: sudo koha-shell <instancename> Run: ./updatedatabase.pl 14. In staff client visit Administration > Global System preferences and search for GuarantorsMustBeLinkedToPatronAccount syspref and confirm it is enabled 15. Repeat steps 1-5 and notice that the guarantor information is not displayed on the new adult's record also in the database confirm the guarantorid, contactname, contactfirstname, relationship are set to NULL. 16. Repeat steps 7-10 and notice that the guarantor information is not displayed on the new adult's record 17. Set GuarantorsMustBeLinkedToPatronAccount syspref to disabled 18. Repeat steps 1-5 and confirm the guarantor information is displayed on the new adult's record (i.e. setting GuarantorsMustBeLinkedToPatronAccount syspref to disabled keeps the current Koha behaviour) also check in the database and confirm that guarantorid is NULL, and contactname, contactfirstname and relationship are not NULL. 19. Repeat steps 7-10 and confirm the guarantor information is displayed Also check in the database and confirm the guarantorid is NULL and contactname, contactfirstname and relationship are not NULL 20. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91724|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23224 [Bug 23224] Inconsistent behaviour between memberentry.pl and the update-child.pl when updating child patron to Adult -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 --- Comment #6 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 91724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91724&action=ed… Bug 12949: (follow-up) Disable syspref by default Implemented fixes based on test feedback: * Set the GuarantorsMustBeLinkedToPatronAccount syspref to 0 (disabled) by default * When syspref is enabled and a guarantee is updated to an 'Adult' their borrowers.guarantorid, borrowers.contactname, borrowers.contactfirstname, borrowers.relationship are reset to NULL. Updated test plan: 1. Create an adult patron (make sure to set a first and last name) and select 'Add child' and save the child record 2. Run the following database query, and notice there are values for guarantorid, contactname, contactfirstname, relationship: SELECT guarantorid, contactname, contactfirstname, relationship FROM borrowers WHERE borrowernumber=<childsborrowernumber>; 3. On the child record select More > Update child to adult patron. 4. Select a new adult patron category and save 5. Notice guarantor information is still displayed on the new adults record 6. Repeat step 2 and notice guarantorid is empty/NULL and contactname and contactfirstname, relationship are unchanged 7. Now create a child record with an unlinked guarantor: In the patron home page select 'New patron'. Note: Make sure the patron category you select is of category type 'Child' 8. In the guarantor area of the patron creation page input a firstname and surname and don't select 'Set to patron' and save/submit the page 9. Repeat step 2 making the borrowernumber you enter the borrowernumber of the patron you made in step 8 and notice guarantorid is empty and contactname and contactfirstname are not empty. i.e. our guarantor is not linked to a Koha patron 10. Notice guarantor information is shown on the patron summary page of our user 11. Repeat step 3,4,5 and notice guarantor information is still displayed 12. Apply patch 13. Navigate to installer/data/mysql directory Enter the Koha shell: sudo koha-shell <instancename> Run: ./updatedatabase.pl 14. In staff client visit Administration > Global System preferences and search for GuarantorsMustBeLinkedToPatronAccount syspref and confirm it is enabled 15. Repeat steps 1-5 and notice that the guarantor information is not displayed on the new adult's record also in the database confirm the guarantorid, contactname, contactfirstname, relationship are set to NULL. 16. Repeat steps 7-10 and notice that the guarantor information is not displayed on the new adult's record 17. Set GuarantorsMustBeLinkedToPatronAccount syspref to disabled 18. Repeat steps 1-5 and confirm the guarantor information is displayed on the new adult's record (i.e. setting GuarantorsMustBeLinkedToPatronAccount syspref to disabled keeps the current Koha behaviour) also check in the database and confirm that guarantorid is NULL, and contactname, contactfirstname and relationship are not NULL. 19. Repeat steps 7-10 and confirm the guarantor information is displayed Also check in the database and confirm the guarantorid is NULL and contactname, contactfirstname and relationship are not NULL 20. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #5 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi Nick, Thanks very much for your test feedback I will make changes now. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lucas(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '19

22 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #169 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 91700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91700&action=ed… Bug 14570: Update schema files [Do Not Push] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '19

22 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #168 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 91699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91699&action=ed… Bug 14570: (follow-up) Fix patron type when "add child" button is pressed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '19

22 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #167 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 91698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91698&action=ed… Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid) -- You are receiving this mail because: You are watching all bug changes.

1 0