July 2019 - Koha-bugs - lists.koha-community.org

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88911|0 |1 is obsolete| | --- Comment #165 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 91732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91732&action=ed… Bug 13937: (follow-up) Pass through yaz switches and don't ignore case Signed-off-by: Stefan Berndtsson <stefan.berndtsson(a)ub.gu.se> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88910|0 |1 is obsolete| | --- Comment #164 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 91731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91731&action=ed… Bug 13937: Add unit tests Signed-off-by: Stefan Berndtsson <stefan.berndtsson(a)ub.gu.se> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88909|0 |1 is obsolete| | --- Comment #163 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 91730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91730&action=ed… Bug 13937: (follow-up) Correct error call to use self Signed-off-by: Stefan Berndtsson <stefan.berndtsson(a)ub.gu.se> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88908|0 |1 is obsolete| | --- Comment #162 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 91729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91729&action=ed… Bug 13937: (follow-up) Remove reference to sub _prefetch_records Remove reference to sub _prefetch_records It appears this sub is built into fetch and this call is a duplicate Signed-off-by: George Williams <george(a)nekls.org> Signed-off-by: Stefan Berndtsson <stefan.berndtsson(a)ub.gu.se> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88907|0 |1 is obsolete| | --- Comment #161 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 91728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91728&action=ed… Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. Signed-off-by: George Williams <george(a)nekls.org> Signed-off-by: Stefan Berndtsson <stefan.berndtsson(a)ub.gu.se> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #160 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Alex, please see comments #43 - #45. The listening port was changed due to conflict with Zebra. I'll provide a test plan for SRU. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22651] New: Update list of commit statistics on git repository start page
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22651 Bug ID: 22651 Summary: Update list of commit statistics on git repository start page Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de Target Milestone: --- (no component for git) The list of versions on the git start page is quite old and should be updated: http://git.koha-community.org/gitweb/ Koha's master branch Koha's 3.8.x branch Koha's 3.6.x branch Koha's 3.4.x branch Koha's 3.2.x branch Koha's 3.0.x branch -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi Nadine and Nick, Thanks for taking the time to test/look at my patches. I've done the following in the follow-up patch I've just attached in response to your notes in comment #4 Nick: Re. point 1. * Renamed the syspref so it has a name more relevant to what it does: RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult * Set the preference to OFF by default so if the library wants the behaviour change they have to actively enable it. Re. point 2. * As the syspref has been renamed to reflect that it doesn't block unlinked patrons from being set as guarantors this should be resolved now. Having said that it could be a good idea in the future to block unlinked patrons from being set as guarantors in another bug report in the future. Re. point 3. * When the aforementioned syspref is enabled then the contactname, contactfirstname and relationship are set to NULL upon a guarantee being updated to a guarantor via members/update-child.pl or members/memberentry.pl Can you please retest? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12949] changing child to adult doesn't remove link to guarantor
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '19

23 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 --- Comment #8 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 91726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91726&action=ed… Bug 12949: (follow-up) Disable syspref by default Implemented fixes based on test feedback: * Renamed syspref now called: RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult * Also set syspref to 0 (disabled) by default * When syspref is enabled and a guarantee is updated to an 'Adult' their borrowers.guarantorid, borrowers.contactname, borrowers.contactfirstname, borrowers.relationship are reset to NULL. Updated test plan: 1. Create an adult patron (make sure to set a first and last name) and select 'Add child' and save the child record 2. Run the following database query, and notice there are values for guarantorid, contactname, contactfirstname, relationship: SELECT guarantorid, contactname, contactfirstname, relationship FROM borrowers WHERE borrowernumber=<childsborrowernumber>; 3. On the child record select More > Update child to adult patron. 4. Select a new adult patron category and save 5. Notice guarantor information is still displayed on the new adults record 6. Repeat step 2 and notice guarantorid is empty/NULL and contactname and contactfirstname, relationship are unchanged 7. Now create a child record with an unlinked guarantor: In the patron home page select 'New patron'. Note: Make sure the patron category you select is of category type 'Child' 8. In the guarantor area of the patron creation page input a firstname and surname and don't select 'Set to patron' and save/submit the page 9. Repeat step 2 making the borrowernumber you enter the borrowernumber of the patron you made in step 8 and notice guarantorid is empty and contactname and contactfirstname are not empty. i.e. our guarantor is not linked to a Koha patron 10. Notice guarantor information is shown on the patron summary page of our user 11. Repeat step 3,4,5 and notice guarantor information is still displayed 12. Apply patch 13. Navigate to installer/data/mysql directory Enter the Koha shell: sudo koha-shell <instancename> Run: ./updatedatabase.pl 14. In staff client visit Administration > Global System preferences and search for RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult syspref and confirm it is disabled 15. Repeat steps 1-5 and notice that the guarantor information is displayed on the new adult's record (i.e. when the RemoveGuarantorDataFromGuaranteeWhenUpdatedToAdult syspref is disabled the current Koha behaviour occurs). 16. In the database confirm the guarantorid is NULL and contactname, contactfirstname and relationship are not set to NULL. 17. Repeat steps 7-10 and notice that the guarantor information is displayed on the new adult's record Also repeat step 16 and confirm the same outcome 18. Set GuarantorsMustBeLinkedToPatronAccount syspref to enabled 19. Repeat steps 1-5 and confirm the guarantor information is not displayed on the new adult's record (i.e. setting GuarantorsMustBeLinkedToPatronAccount syspref to enabled implements the behaviour change). Also repeat step 16 and confirm the guarantorid, contactname, contactfirstname and relationship are all NULL 20. Repeat steps 7-10 and confirm the guarantor information is not displayed Also repeat step 16 and confirm the guarantorid, contactname, contactfirstname and relationship are NULL 21. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0