July 2019 - Koha-bugs - lists.koha-community.org

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 Chris Slone <cslone(a)camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #81 from M. Tompsett <mtompset(a)hotmail.com> --- Found some issues with the StaffClientBaseUrl. http://http:// :( -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #80 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91192&action=ed… Bug 1985: Follow up - Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Left signed off, even though uk-UA was rebased. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #79 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91191&action=ed… Bug 1985: Send email alert when comment posted. Many blog systems have a feature where the admin gets an email when someone posts a new comment that needs to be moderated. It would be nice to incorporate this into Koha. Ideally, you could set an email address in system preferences where notifications should be sent (since the Koha administrator is probably not the one approving comments). The body of the email would contain the comments, and offer a direct link to approve or delete the comment. The authorship was corrected to Olli-Antti Kivilahti. In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74769|0 |1 is obsolete| | Attachment #74770|0 |1 is obsolete| | Attachment #74771|0 |1 is obsolete| | --- Comment #78 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91190&action=ed… Bug 1985: Fix whitespace in opac/opac-review.pl $ git diff -w origin/master -- should have no differences Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20514] New: Searching for a patron using the search field (street address) returns no results if inputting a address stored in multiple db fields
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20514 Bug ID: 20514 Summary: Searching for a patron using the search field (street address) returns no results if inputting a address stored in multiple db fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If inputting a street address of street number and street name which are stored in different db fields (e.g. 'streetnumber' and 'address') this does not return patron results. If however the street number and name are stored in the same db field then results are returned for your search query. At present the only way to search with the search field of address is to either enter ONLY a streetnumber OR a street name unless they are both stored in the same db field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 22878] New: cannot add a patron card layout with mysql strict mode on
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22878 Bug ID: 22878 Summary: cannot add a patron card layout with mysql strict mode on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: wizzyrea(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 [for Statement "INSERT INTO creator_layouts (creator, layout_id, units, layout_xml, layout_name) VALUES (?,?,?,?,?);" with ParamValues: 0='Patroncards', 1="", 2="POINT", 3="<opt guide_box="0" guide_grid="0" page_side="F" units="POINT"> </opt> ", 4="something"] at /kohadevbox/koha/C4/Creators/Layout.pm line 181. Database returned the following error: Incorrect integer value: '' for column 'layout_id' at row 1 at /kohadevbox/koha/C4/Creators/Layout.pm line 183. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 22886] New: Missing space between fields from Keyword to MARC mapping in catalouging search
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '19

02 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22886 Bug ID: 22886 Summary: Missing space between fields from Keyword to MARC mapping in catalouging search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Target Milestone: --- If you've added multiple subfields to the "subtitle" Keyword to MARC mapping they display without a space between them in the cataloguing search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11