July 2019 - Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |agustinmoyano(a)theke.io CC| |joy(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9805] Lost items are un-lost if returned, but not if renewed
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Chris Slone <cslone(a)camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287 --- Comment #13 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #10) > Please provide a test plan. > > NormalizeISBN is used in some places and it's hard to imagine the side > effects this patch could introduce. Actually, GetNormalizedISBN is what is more broadly used. It calls _isbn_cleanup which calls NormalizeISBN. It would also seem that this is used to grab book covers using the ISBN-10. Take Amazon for example. https://www.amazon.com/Tolkiens-Failed-Quest-Michael-Jones/dp/1521406812/ That's an ISBN-10. https://www.amazon.com/Apprenez-%C3%A0-programmer-2e-%C3%A9dition/dp/B006MV… That's an ASIN which is Amazon's own unique ID, because it is ISBN-13 only: 979-1090085008 But what about "The Hobbit"? ISBN-13: 9780547928227 ISBN-10: 054792822X https://www.amazon.com/Hobbit-J-R-Tolkien/dp/054792822X/ So, how are we supposed to grab Amazon covers? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #87 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91198&action=ed… Bug 1985: (follow-up) Fix Reviews.t logic Read the tests to make sure they make sense. Before the patch is applied, they don't. $nb_of_approved_reviews + 2 did not make sense, because the three reviews added were not approved. search->count counts everything, so the use of approved+3 didn't make sense. Rather than duplicate the search->count test, changed the first one to reflect that the added reviews were all unapproved. Before applying patch, prove fails. After applying patch, prove passes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #86 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91197&action=ed… Bug 1985: (follow-up) fix staff URL in other letters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #85 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91196&action=ed… Bug 1985: (follow-up) Add letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Left signed off, even though uk-UA was rebased. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #84 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91195&action=ed… Bug 1985: (follow-up) correct http:// in staff URL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #83 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91194&action=ed… Bug 1985: Send email alert when comment posted. Many blog systems have a feature where the admin gets an email when someone posts a new comment that needs to be moderated. It would be nice to incorporate this into Koha. Ideally, you could set an email address in system preferences where notifications should be sent (since the Koha administrator is probably not the one approving comments). The body of the email would contain the comments, and offer a direct link to approve or delete the comment. The authorship was corrected to Olli-Antti Kivilahti. In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '19

03 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91190|0 |1 is obsolete| | Attachment #91191|0 |1 is obsolete| | Attachment #91192|0 |1 is obsolete| | --- Comment #82 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 91193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91193&action=ed… Bug 1985: Fix whitespace in opac/opac-review.pl $ git diff -w origin/master -- should have no differences Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0