August 2019 - Koha-bugs - lists.koha-community.org

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '19

20 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88297|0 |1 is obsolete| | --- Comment #70 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 92376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92376&action=ed… Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rebased on master (2016-03-11) Rebased on master (2016-06-23) Rebased on master (2017-03-23) Rebased on master (2018-03-15) Rebased on master (2019-04-18) Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '19

20 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 --- Comment #17 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Michal Denar from comment #16) > Hi Martin, > is test plan right? We solve ISSUEQSLIP but test plan says: "Replace your > ISSUESLIP with the following". Is ot correct? You are correct Michal.. it should be ISSUEQSLIP. I didn't notice that when rescuing the patch.. it's always dealt with the Q variety, just always had an incorrect test plan.. oops. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23472] New: Amazon image size should be configurable in OPAC results/details
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23472 Bug ID: 23472 Summary: Amazon image size should be configurable in OPAC results/details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Amazon offers several different cover image sizes: Examples: https://images-na.ssl-images-amazon.com/images/P/0765322730.01.TZZZZZZZ.jpg https://images-na.ssl-images-amazon.com/images/P/0765322730.01.MZZZZZZZ.jpg https://images-na.ssl-images-amazon.com/images/P/0765322730.01.LZZZZZZZ.jpg There should be an option to select which size should display on the OPAC results/details page. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com --- Comment #16 from Michal Denar <black23(a)gmail.com> --- Hi Martin, is test plan right? We solve ISSUEQSLIP but test plan says: "Replace your ISSUESLIP with the following". Is ot correct? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15284] Switch default ISSUESLIP notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Signed Off |BLOCKED --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Currently blocked by depency needing sign-off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92202|0 |1 is obsolete| | --- Comment #37 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92351&action=ed… Bug 11677: Use zebra not-onloan-count index for availability limit This uses the work from bug 18098 to use the count of not-onloan items to determine availability. It keeps the allrecords,AlwaysMatches='' portion of the query so it still catches records with the tested indexed missing. These shouldn't exist except in the case of missing data, but kept for future use as well as it has no negative impact and minimizes the change made. Note that availability in this sense means not check out and not lost. Transfers, holds, and not for loan statuses should probably have indexes built in the same way as bug 18098 (there are related FIXMEs in the code) This updates the export_records file used for testing - adding three records with a not-onloan-count (999$x) of 1, but marking the item on the third record lost to prevent its return To test: 1 - make sure SearchEngine pref is set to 'Zebra' 2 - Do a search on the OPAC that returns some records 3 - Find a record in those results with more than one 1 item, and checkout 1 leaving 1 (or more) available 4 - Find another record with only 1 item, check that item out 5 - Limit opac search to available items - both records disappear 6 - Apply patch 7 - Restart all the things 8 - Repeat search 9 - First record should show, but no second 10 - Mark other items of first record as lost, return items on second record 11 - Repeat search, first record should not be in results, second should 12 - prove -v t/db_dependent/Search.t Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11677] Limit to Only items currently available for loan or reference not working
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #238 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92350&action=ed… Bug 14570: Add about.pl entry for wrong relationship data This patch adds a check and an entry to the about.pl, for bad relationship data. The checks are: - 'relationship' containing '_bad_data' (generated by the atomicupdate on undef relationships. - 'relationship' values that are not in the borrowerRelationship syspref. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #237 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92349&action=ed… Bug 14570: (QA follow-up) Call Koha::Patron->find in scalar context This patch prevents opac/opac-memberentry.pl from exploding. To test: - Login with a known user in the OPAC - Open the opac/opac-memberentry.pl page => FAIL: It explodes - Apply this patch - Restart all the things just in case: $ restart_all - Reload the page => SUCCESS: Things work! Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #236 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92348&action=ed… Bug 14570: Handle missing 'relationship' in atomicupdate (bad data) This patch adds two steps to the upgrade process: - Handle the pathologic case in which there's a guarantorid and no 'relationship'. - Performs a cleanup on the relevant columns when the guarantor data contains a guarantorid, and is then migrated into the borrower_relationships table. The original code left the information in the borrowers table, so no clear separation between guarantors as patrons and the virtual ones. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0