August 2019 - Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #235 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92347&action=ed… Bug 14570: (QA follow-up) Fix tests Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #234 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 92346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92346&action=ed… Bug 14570: (QA follow-up) Consistency displaying the list of guarantors Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23471] New: The accordion when modifying notices should make better use of screen size
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23471 Bug ID: 23471 Summary: The accordion when modifying notices should make better use of screen size Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Currently, when you expand a notice in the accordion we are only using a fixed height div.. it would be nice to use all the available vertical screen space so more of the notice template may be visible at one time on the screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Patrick Robitaille <patrick.robitaille(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #233 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Martin Renvoize from comment #232) > I'm afraid the DB update fails for a few test runs I've tried. > > borrowers.relationship has no constraints to it so it's very possible we > have guarantor_relationships without a valid relationship and so the db > update fails. > > We need to come up with a solution for this before I can push the patch > series.. I'm not sure whether to reduce the 'NOT NULL' constraint on the new > table or set a default or note the issue as an error somewhere and populate > the table with some sort of placeholder relationship whilst libraries work > through fixing up the bad data.. > > Thoughts? There's no semantic on the relationship field ATM, so I think it being just a label, we should not fail because of it. If we were to add some semantics, we would have a separate table, with the relationship description and probably some columns for describing rules. If such was the situation, I would pick a placeholder as you say, so we don't fail, and even have an entry in about.pl about those problematic cases (maybe a note field with the original value). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20712] New: ILL belongs to the circulation section
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20712 Bug ID: 20712 Summary: ILL belongs to the circulation section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I belive the ILL handling UI belongs more to the Circulation section than the main staff page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 19 Aug '19

19 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #232 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I'm afraid the DB update fails for a few test runs I've tried. borrowers.relationship has no constraints to it so it's very possible we have guarantor_relationships without a valid relationship and so the db update fails. We need to come up with a solution for this before I can push the patch series.. I'm not sure whether to reduce the 'NOT NULL' constraint on the new table or set a default or note the issue as an error somewhere and populate the table with some sort of placeholder relationship whilst libraries work through fixing up the bad data.. Thoughts? -- You are receiving this mail because: You are watching all bug changes.

1 0