August 2019 - Koha-bugs - lists.koha-community.org

[Bug 23440] New: Advanced cataloging editor: Don't show 'Duplicate' as an option when working on a new record
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '19

09 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23440 Bug ID: 23440 Summary: Advanced cataloging editor: Don't show 'Duplicate' as an option when working on a new record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When working on a new record the Save to > Duplicate action makes no sense. We should only show that when working on an existing record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '19

09 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91951|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 92104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92104&action=ed… Bug 13552: (follow-up) Add debar option to batch patron modification As per test feedback I've changed wording from debarrment to restriction Added insertion into the borrower_debarments table and removal from borrower_debarments table (and borrowers.debarred and borrowers.debarredcomment) when either 'Restriction expiration' or 'Restriction comment' are ticket to be disabled/deleted. Test plan (please follow this instead of following test plan in the first patch): 1. Go to Tools > Batch patron modification 2. Input the cardnumbers of several (undebarred/unrestricted) patrons and submit 3. Notice there is no input for setting Restriction expiration date or Restriction comment Also notice in the list of matching borrowers at the top of the page there is no display of the 'Restriction expiration' or 'Restriction comment' values for the patron 4. Apply patch 5. Restart memcached and plack 6. Refresh the page notice 'Restriction expiration' (a date picker input) and 'Restriction comment'are now input options Also notice in the table at the top of the page 'Restriction expiration' and 'Restriction comment' are shown on the far right of the table (you may need to scroll to see this) 7. Pick a date in the 'Restriction expired' datepicker and write in text into the 'Restriction comment' field and submit 8. Notice in the next loaded page the selected patrons have the 'Restriction expiration' and 'Restriction comment' values you entered 9. Query the borrower_debarments database table and check that the new debarments are added to this table 10. Go back to the Batch patron modification page and re-input the same cardnumbers 11. Write text into the 'Restriction comment' field and don't pick a 'Restriction expiration' value and submit 12. Notice in the next loaded page the selected patrons have the 'Restriction expiration' value of 9999-12-31 and 'Restriction comment' value you just entered 13. Query the borrowers table and notice the borrowers.debarred value for the modified patrons is '9999-12-31' and the borrower.debarredcomment is what you inputted in step 11 14. Query the borrower_debarments table and notice the expiration value is NULL and the comment value is set to what you entered in step 11 Also note the addition of the new debarment has not removed the existing debarment on the patrons 15. Click on the cardnumber link of one of the patrons and notice the red text on their patron account page informing you they are restricted until the date you set 16. In the Koha home directory enter Koha shell: sudo koha-shell <instancename> 17. Run: prove xt 18. All tests should pass 19. Repeat step 10 and tick the checkbox beside the 'Restriction expiration' field and submit 20. In the next loaded screen notice the 'Restricted expiration'and 'Restricted comment' are empty Check the borrower_debarments table and notice all restrictions for the patron are removed. Check the borrowers table and notice the debarred and debarredcomment fields are empty for the patrons 21. Repeat steps 10 and 11 to make a new restriction 22. Repeat step 19 and this time check the 'Restriction comment' field and submit and observe that also clears the restriction in the next loaded page, in the borrower_debarments and borrowers table 23. Sign off Sponsored-By: Brimbank Library, Australia Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '19

09 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91950|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 92103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92103&action=ed… Bug 13552: Add debar option to batch patron modification Test plan: 1. Go to Tools > Batch patron modification 2. Input the cardnumbers of several (undebarred/unrestricted) patrons and submit 3. Notice there is no input for setting a debarred until (restriction expiration) date or debar comment Also notice in the list of matching borrowers at the top of the page there is no display of the debarred or debarredcomment values for the patron 4. Apply patch 5. Restart memcached and plack 6. Refresh the page notice 'Debarred till' (a date picker input) and 'Debarred comment' are now input options Also notice in the table at the top of the page 'Debarred till' and 'Debarred comment' are shown on the far right of the table (you may need to scroll to see this) 7. Pick a date in the 'Debarred till' datepicker and write in text into the 'Debarred comment' field and submit 8. Notice in the next loaded page the selected patrons have the 'Debarred till' and 'Debarred comment' values you entered 9. Click on the cardnumber link of one of the patrons and notice the red text on their patron account page informing you they are restricted until the date you set 10. In the Koha home directory enter Koha shell: sudo koha-shell <instancename> 11. Run: prove xt 12. Confirm all tests pass 13. Sign off Sponsored-By: Brimbank Library, Australia Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '19

09 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20270] New: SIP2 Connection Issue
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '19

09 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20270 Bug ID: 20270 Summary: SIP2 Connection Issue Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: aniltiwari86(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Created attachment 72087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72087&action=ed… SIP Log Hi, We have Installed Koha 17.05.06.000, and created multiple SIP users to integrate with RFID Kiosk. When we are trying to connect with one kiosk it works perfectly. If we try to connect more Kiosk the SIP2 is not responding to 93 packet. Can you please suggest what could be the issue. Regards, Anil -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '19

08 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #96 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 4) Method naming I believe we agreed on lower case using _ for dividing words for all methods in the new Koha namespace. SendReviewAlert -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '19

08 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #95 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx for taking this up - also impressed with letters added for all translations :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '19

08 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #94 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- QA review: 1) Letter text +We want to inform you that borrower <<borrowers.cardnumber>> has just created a new comment on <<biblio.title>>, which is biblionumber <<biblio.biblionumber>>. Instead of telling the biblionumber in the text, why not add a link to the record instead? To make this title more distinguishable we could also make use of the new fields (subtitle, parts, number). These seem a bit unusual and very developery for formatting: +--- BEGIN COMMENT --- +<<reviews.review>> +--- END COMMENT --- I think using standard formatting or just ----- would work better here. Signing a letter to the libray with 'the library' seems a little odd to me :) 2) Convert database update to .perl The RM will be happier. 3) Capitalization +('CommentModeratorsEmail','','','The email address where to send a notification (template code COMMENT_CREATED) when a Borrower adds/modifies a review/comment for a Biblio. Set to empty to disable sending email notifications.','Textarea'), Biblio and Borrower... Same for the description in the SQL statements. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11492] Receiving a serial item causes routing list notes to be lost
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '19

08 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11492 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23416 [Bug 23416] When a note to a specific issue upon receiving a serial, this note will appear in next issue received -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '19

08 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91537|0 |1 is obsolete| | --- Comment #82 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 92081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92081&action=ed… Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.

1 0