August 2019 - Koha-bugs - lists.koha-community.org

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91981&action=ed… Bug 15522: Add yarn.lock (autogenerated) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91980&action=ed… Bug 15522: Remove old circulation rules interface -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91979&action=ed… Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91978&action=ed… Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71048|0 |1 is obsolete| | Attachment #71049|0 |1 is obsolete| | Attachment #71050|0 |1 is obsolete| | Attachment #71051|0 |1 is obsolete| | Attachment #72242|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91977&action=ed… Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15395 |21156 Assignee|kyle(a)bywatersolutions.com |jonathan.druart(a)bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 [Bug 15395] Internationalization: plural forms, context, and more https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15522 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 [Bug 15522] New interface for revamped circulation rules -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20654] New: Omnibus: Update two-column templates to use Bootstrap grid
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '19

04 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug ID: 20654 Summary: Omnibus: Update two-column templates to use Bootstrap grid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 14546 This omnibus bug will cover bugs which update two-column template grid markup from YUI to Bootstrap. Typical markup to be replaced: <div id="doc3" class="yui-t2"> <div id="bd"> <div id="yui-main"> <div class="yui-b">  </div> </div> <div class="yui-b">  </div> </div> </div> Replacement: <div class="main container-fluid"> <div class="row"> <div class="col-sm-10 col-sm-push-2">  </div> <div class="col-sm-2 col-sm-pull-10">  </div> </div> </div> Note that "col-sm-push-2" and "col-sm-pull-10" are the classes that reverse the visible column order in the desktop layout. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive -- You are receiving this mail because: You are watching all bug changes.

1 103

[Bug 14546] Make staff client templates responsive
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '19

04 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 20654, which changed state. Bug 20654 Summary: Omnibus: Update two-column templates to use Bootstrap grid https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0