August 2019 - Koha-bugs - lists.koha-community.org

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '19

04 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 91951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91951&action=ed… Bug 13552: (follow-up) Add debar option to batch patron modification As per test feedback I've changed wording from debarrment to restriction Added insertion into the borrower_debarments table and removal from borrower_debarments table (and borrowers.debarred and borrowers.debarredcomment) when either 'Restriction expiration' or 'Restriction comment' are ticket to be disabled/deleted. Test plan (please follow this instead of following test plan in the first patch): 1. Go to Tools > Batch patron modification 2. Input the cardnumbers of several (undebarred/unrestricted) patrons and submit 3. Notice there is no input for setting Restriction expiration date or Restriction comment Also notice in the list of matching borrowers at the top of the page there is no display of the 'Restriction expiration' or 'Restriction comment' values for the patron 4. Apply patch 5. Restart memcached and plack 6. Refresh the page notice 'Restriction expiration' (a date picker input) and 'Restriction comment'are now input options Also notice in the table at the top of the page 'Restriction expiration' and 'Restriction comment' are shown on the far right of the table (you may need to scroll to see this) 7. Pick a date in the 'Restriction expired' datepicker and write in text into the 'Restriction comment' field and submit 8. Notice in the next loaded page the selected patrons have the 'Restriction expiration' and 'Restriction comment' values you entered 9. Query the borrower_debarments database table and check that the new debarments are added to this table 10. Go back to the Batch patron modification page and re-input the same cardnumbers 11. Write text into the 'Restriction comment' field and don't pick a 'Restriction expiration' value and submit 12. Notice in the next loaded page the selected patrons have the 'Restriction expiration' value of 9999-12-31 and 'Restriction comment' value you just entered 13. Query the borrowers table and notice the borrowers.debarred value for the modified patrons is '9999-12-31' and the borrower.debarredcomment is what you inputted in step 11 14. Query the borrower_debarments table and notice the expiration value is NULL and the comment value is set to what you entered in step 11 Also note the addition of the new debarment has not removed the existing debarment on the patrons 15. Click on the cardnumber link of one of the patrons and notice the red text on their patron account page informing you they are restricted until the date you set 16. In the Koha home directory enter Koha shell: sudo koha-shell <instancename> 17. Run: prove xt 18. All tests should pass 19. Repeat step 10 and tick the checkbox beside the 'Restriction expiration' field and submit 20. In the next loaded screen notice the 'Restricted expiration'and 'Restricted comment' are empty Check the borrower_debarments table and notice all restrictions for the patron are removed. Check the borrowers table and notice the debarred and debarredcomment fields are empty for the patrons 21. Repeat steps 10 and 11 to make a new restriction 22. Repeat step 19 and this time check the 'Restriction comment' field and submit and observe that also clears the restriction in the next loaded page, in the borrower_debarments and borrowers table 23. Sign off Sponsored-By: Brimbank Library, Australia Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '19

04 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91425|0 |1 is obsolete| | Attachment #91433|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 91950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91950&action=ed… Bug 13552: Add debar option to batch patron modification Test plan: 1. Go to Tools > Batch patron modification 2. Input the cardnumbers of several (undebarred/unrestricted) patrons and submit 3. Notice there is no input for setting a debarred until (restriction expiration) date or debar comment Also notice in the list of matching borrowers at the top of the page there is no display of the debarred or debarredcomment values for the patron 4. Apply patch 5. Restart memcached and plack 6. Refresh the page notice 'Debarred till' (a date picker input) and 'Debarred comment' are now input options Also notice in the table at the top of the page 'Debarred till' and 'Debarred comment' are shown on the far right of the table (you may need to scroll to see this) 7. Pick a date in the 'Debarred till' datepicker and write in text into the 'Debarred comment' field and submit 8. Notice in the next loaded page the selected patrons have the 'Debarred till' and 'Debarred comment' values you entered 9. Click on the cardnumber link of one of the patrons and notice the red text on their patron account page informing you they are restricted until the date you set 10. In the Koha home directory enter Koha shell: sudo koha-shell <instancename> 11. Run: prove xt 12. Confirm all tests pass 13. Sign off Sponsored-By: Brimbank Library, Australia Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '19

04 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22144] New: Add method marc() to Koha::Biblio
by bugzilla-daemon＠bugs.koha-community.org 04 Aug '19

04 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22144 Bug ID: 22144 Summary: Add method marc() to Koha::Biblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- It would be very convenient to be able to retrieve a bib's MARC::Record object directly from biblio object. This would be very useful for Template Toolkit syntax in slips and notices where a library would like to use arbitrary MARC fields that aren't stored in the database. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 35

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '19

02 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 --- Comment #15 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 91943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91943&action=ed… Bug 14549: POD and variable cleanup Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '19

02 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 --- Comment #14 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 91942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91942&action=ed… Bug 14549: Check patrons reserves for any holds on a bib when checking out an item MoveReserve uses CheckReserves to see if the current patron has any holds on the title they are checking out, however, CheckReserves doesn't return all holds on a biblio, it returns holds on the item from the holdsqueue if they exist This can create a condition where we check holds on an item, find we have it planned for another borrower, confirm checkout to the current borrower, but don't fill their hold To test: 1) Find record 2) place record level holds for 2 different patrons (record level) 3) Run holds queue builder, check the queue to confirm an item was selected for patron 1 Circulation->Holds queue->Library="All" 4) Check out the item queued for patron with priority 1 to the second patron 5) You should be asked to confirm, do so 6) Note the item checks out, but both holds remain 7) Apply patch 8) Check in the item 9) Don't confirm the hold 10) Check the holds on the record and the holds queue 11) Patron 1 should be priority 1 with an item selected from the holds queue 12) Checkout to patron 2 as before 13) Note the hold for patron 2 is filled this time 14) Prove -v t/db_dependent/Reserves.t Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '19

02 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 --- Comment #13 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 91941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91941&action=ed… Bug 14549: Unit tests To test: 1 - Apply just this patch 2 - prove -v t/db_dependent/Reserves.t 3 - Failure 4 - Apply second patch 5 - prove -v t/db_dependent/Reserves.t 6 - Success! Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '19

02 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '19

02 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '19

02 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91776|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0