August 2019 - Koha-bugs - lists.koha-community.org

[Bug 9273] Add price and replacement price fields to subscriptions for auto-populating items
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9273 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Rather than adding two new fields price and replacement price to the subscription table we decided to auto-populate items from the aqorders.unitprice and aqorders.replacementprice defined when adding the subscription to a order. This further builds on Bug 5343 *** This bug has been marked as a duplicate of bug 23352 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Screenshot: https://snag.gy/ujakOo.jpg -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_15522 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #30 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91984&action=ed… Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91983&action=ed… Bud 15522: Restore categories filtering Mimicking what is done for Branches -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91982&action=ed… Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91981&action=ed… Bug 15522: Add yarn.lock (autogenerated) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91980&action=ed… Bug 15522: Remove old circulation rules interface -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91979&action=ed… Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '19

05 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 91978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91978&action=ed… Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work -- You are receiving this mail because: You are watching all bug changes.

1 0