September 2019 - Koha-bugs - lists.koha-community.org

[Bug 23599] New: Koha::Objects::Limit::Library fails if no library passed
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23599 Bug ID: 23599 Summary: Koha::Objects::Limit::Library fails if no library passed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The search_with_library_limits method is not tested, and when used in 15497 it proved to explode when no library is passed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 23512] New: Reindent notices and slips page (letter.tt)
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Bug ID: 23512 Summary: Reindent notices and slips page (letter.tt) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I would like to reindent tools/letter.tt: Correct indentation, replace tabs with spaces, and add some comments to clarify the structure. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #54 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased on master (In reply to Fridolin SOMERS from comment #47) > (In reply to Fridolin SOMERS from comment #46) > > A bug as been found on relatives checkouts Bug 22921. > > It turns out its a bug from this feature. > > Needs a fix Fix attached (attachment 92781) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #53 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 92781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92781&action=ed… Bug 15219: Fix relatives checkouts Send all borrowernumbers to /svc/checkouts instead of only the last one -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79199|0 |1 is obsolete| | --- Comment #52 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 92780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92780&action=ed… Bug 15219: Reword "select all" links since they select only visible rows -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79198|0 |1 is obsolete| | --- Comment #51 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 92779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92779&action=ed… Bug 15219: Do not call escapeHtml on null values -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79197|0 |1 is obsolete| | --- Comment #50 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 92778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92778&action=ed… Bug 15219: Fix relatives issues table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79196|0 |1 is obsolete| | --- Comment #49 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 92777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92777&action=ed… Bug 15219: Fix date sorting when server-side processing is disabled Use DataTables 'columns' option instead of 'aoColumns' This allow more control on what data is used for display, sorting, filtering, ... A large part of this patch is about rewording things to better match the DataTables documentation. The real change is that "mRender": renderingFunc becomes "render": { "display": renderingFunc } So the return value of renderingFunc is now only used for display (not for filtering, sorting, ...) Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79195|0 |1 is obsolete| | --- Comment #48 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 92776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92776&action=ed… Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '19

13 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92740|0 |1 is obsolete| | --- Comment #59 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Created attachment 92774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92774&action=ed… Bug 7376 Transfer limits should be checked at check-in Oups ! sorry, the previous patch was for version 17.11. Here's the one for master Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.

1 0