September 2019 - Koha-bugs - lists.koha-community.org

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92737|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 92743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92743&action=ed… Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo <jzairo(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92736|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 92742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92742&action=ed… Bug 15497: Modify schemas Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo <jzairo(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92735|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 92741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92741&action=ed… Bug 15497: Add itemtypes_branches table and atomic update Sponsored-by: Northeast Kansas Library System Sponsored-by: Southeast Kansas Library System Sponsored-by: Central Kansas Library System Signed-off-by: Jessica Zairo <jzairo(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #27 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Martin Renvoize from comment #26) > All works well for me and passes QA scripts... No obvious regressions. > > Passing QA. Thanks! > Some minor additions in the future might be nice.. there's nothing that ties > this in at the circ rules level.. one can still create a circ rule at any > branch with any itemtype for example and there's nothing to prevent an item > being permanently transferred to the branch without that itemtype and as > such you end up with an incorrectly types item at that branch. > > I don't see either of the above as failure points, but perhaps worth > mentioning and perhaps a followup bug creating to document these > shortcomings. I'm sure the consortia that sponsored this dev will have interesting additions and requests to make now that this is in master and can have a real-life test drive! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76876|0 |1 is obsolete| | --- Comment #58 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Created attachment 92740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92740&action=ed… Bug 7376 Transfer limits should be checked at check-in to answer to Victor (comment 56), the response is no, seems that bug 22330 don't encompass this one. When you return an unauthorized item (according to the branch transfer limits table), you get only a message "Please return this item to such branch", but the return is done as well. So the need to add a checking on branch transfert status is still on the agenda. The patch proposed is essentially the initial one from Martin Renvoize with a little variant to tie the checking with the "anywhere" position of ReturnToBranch syspref (because a priori, the need is much likely to appear in this case). Test Plan : * ReturnToBranch must be set to "anywhere" * UseBranchTransferLimits must be set 1) define your branch transfer limit. Refuse transfers from libraryA to libraryOwner (= refuse return at libraryA of a book located at libraryOwner). 2) checkout a book owned by libraryOwner, at libraryOwner, with a librarian located at libraryOwner 3) move the librarian to libraryA ("Set Library" link top/right) 4) check-in the book => "you get the message Please return this item to libraryOwner" Note that you get the same message whether the transfert from libraryA to libraryOwner is authorized or not. 5) Install the patch 6) Redo steps 2 to 4 The message you get now at step 4 is "Cannot check in ... This item must be checked in at following library: libraryOwner" Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #26 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- All works well for me and passes QA scripts... No obvious regressions. Passing QA. Some minor additions in the future might be nice.. there's nothing that ties this in at the circ rules level.. one can still create a circ rule at any branch with any itemtype for example and there's nothing to prevent an item being permanently transferred to the branch without that itemtype and as such you end up with an incorrectly types item at that branch. I don't see either of the above as failure points, but perhaps worth mentioning and perhaps a followup bug creating to document these shortcomings. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92732|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 92739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92739&action=ed… Bug 15497: (QA follow-up) Fix call in search_with_localization Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92728|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 92738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92738&action=ed… Bug 15497: (QA follow-up) Use the methods from bug 23281 instead Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92727|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 92737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92737&action=ed… Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off Signed-off-by: Jessica Zairo <jzairo(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15497] Limit Item Types by Branch
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '19

12 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92726|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 92736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92736&action=ed… Bug 15497: Modify schemas Signed-off-by: Jessica Zairo <jzairo(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0