October 2020 - Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #133 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 112163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112163&action=e… Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #132 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 112162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112162&action=e… Bug 12446: Schema update Category.pm Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #131 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 112161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112161&action=e… Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111317|0 |1 is obsolete| | Attachment #111318|0 |1 is obsolete| | Attachment #112102|0 |1 is obsolete| | --- Comment #130 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 112160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112160&action=e… Bug 26751: Fix fatal exception if only one repo defined This patch fixes this nasty problem with how XML is parsed: if more than one entry is found, repo => [] is generated. If only one, repo => {}. To test: 1. Have more than one entries in the plugins_repo entry: <plugin_repos> <repo> <name>ByWater Solutions</name> <org_name>bywatersolutions</org_name> <service>github</service> </repo> <repo> <name>Theke Solutions</name> <org_name>thekesolutions</org_name> <service>github</service> </repo> <repo> <name>PTFS Europe</name> <org_name>ptfs-europe</org_name> <service>github</service> </repo> </plugin_repos> 2. Search for plugins => SUCCESS: Searching works! 3. Leave only one entry 4. Restart all to refresh things 5. Try searching for plugins => FAIL: Fatal error 6. Apply this patch 7. Repeat 5 => SUCCESS: It doesn't explode anymore! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22750] New: Partial writeoff of lost fee causes item to be returned
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22750 Bug ID: 22750 Summary: Partial writeoff of lost fee causes item to be returned Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- To test: - Set system preference MarkLostItemAsReturned to not mark items as returned - Set system preference WhenLostChargeReplacementFee to charge - Find an item with a non-zero replacement cost - Check item out to patron - Mark item as lost - Confirm item is still in patron checkouts and patron has a lost fee for item - Write off part of the lost fee - Confirm the item no longer shows in patron checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #41 from David Cook <dcook(a)prosentient.com.au> --- I do have another idea... based on what Dobrica said at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437#c7 When using Plack, we could re-direct away from export.pl to a URL where we have mounted a PSGI application (e.g. we could use Mojo::Serve::PSGI like we do with the REST API). This would also give us a path forward to transition away from CGI to Plack. The tools/export.pl file is actually pretty short, and the majority of the logic is in Perl modules (the "model" in MVC terms). The .pl files are basically just overloaded controllers (in MVC terms). I don't have time today, but maybe I would be willing to work on a solution for this. We could keep the existing template file (or "view" in MVC terms), and just provide an alternative controller. We could deprecate tools/export.pl and focus in favour on a PSGI controller. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #40 from David Cook <dcook(a)prosentient.com.au> --- I can't figure out why the problem with CGI::Emulate::PSGI::Streaming is happening, but I've reported the bug. It's unusable until it's fixed though. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #39 from David Cook <dcook(a)prosentient.com.au> --- That truncated response is 32489 bytes long... I'm guessing the issue is with CGI::Parse::PSGI::Streaming... According to the tools/export.pl, I'm writing a body of 33441 characters... Looking at CGI::Parse::PSGI::Streaming, I'm only seeing 32768 characters (which includes the HTTP headers and the HTTP body), and 32768 bytes is the same as 32KB... CGI::Parse::PSGI::Streaming::Handle shows the full response in the buffer and says it is 33750 characters long... Ah, I think it's a bug in CGI::Parse::PSGI::Streaming::Handle. For some reason, the author takes the data printed to STDOUT, creates an in-memory file handle stored in a scalar variable, and prints the contents of that "STDOUT" to the in-memory file handle, and that's when it is truncated from 33750 characters to 32768 characters... This is the line in CGI::Parse::PSGI::Streaming::Handle which seemingly breaks things: print {$self->{fh}} substr($buf, $offset, $len); The weird thing is that I'm trying to reproduce the problem in a more stripped back program and I can't do it. It just works... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #38 from David Cook <dcook(a)prosentient.com.au> --- For some reason, my HTML response is being cut off here: <script> $(document).ready(function() { $('#exporttype').tabs(); $("li.csv_profiles").hide(); $("#bibs select[name='output_format']").on('change', function(){ var format = $(this).val(); if ( format == 'csv' ) { $("#bibs li.csv_profiles").show(); } else { $("#bibs li.csv_profiles").hide(); } }); $("#checkall").on("click",function(e){ e.preventDefault(); $(".branch_select").prop("checked",1); }); $("#checknone").on("click",func -- You are receiving this mail because: You are watching all bug changes.

1 0