October 2020 - Koha-bugs - lists.koha-community.org

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #37 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #36) > Hmm the difference seems to be in the HTML... Ahh my custom handler isn't sending a complete HTML response for some reason. I think a Perl error. I think I must not be setting up the CGI env quite right. But so close... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #36 from David Cook <dcook(a)prosentient.com.au> --- Hmm the difference seems to be in the HTML... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #35 from David Cook <dcook(a)prosentient.com.au> --- One alternative could be to use https://metacpan.org/pod/Plack::App::CGIBin::Streaming. Another would be a custom handler using CGI::Emulate::PSGI::Streaming: cpan2deb CGI::Emulate::PSGI::Streaming apt install ./libcgi-emulate-psgi-streaming-perl_1.0.0-1_all.deb I'm exploring the second option now (via a custom Koha::Plack::App::StreamCGI module)... It seems like the custom handler is returning an empty koha.mrc file after about 10 seconds, and I've only processed about 6000 out of 40000 records... Of course, as soon as I say that, suddenly it seems to start working without me doing anything different. Although I notice that usually my custom handler doesn't load some Javascript or CSS quite right... and I hit the "Export bibliographic records" button from a different window... But still... progress... I've streamed 10,000 bib records (10MB) out of Starman via Apache. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #34 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #33) > As Dobrica mentioned, it does appear that Starman is buffering the whole > response before sending it. I am guessing this is due to our usage of > Plack::App::CGIBin... but I'll investigate further. If I understand correctly, this will never work for us, so long as we're using Plack::App::CGIBin to serve export.pl. At https://metacpan.org/release/Plack/source/lib/Plack/App/CGIBin.pm#L47, Plack::App::CGIBin uses Plack::App::WrapCGI. Plack::App::WrapCGI uses CGI::Emulate::PSGI at https://metacpan.org/source/Plack::App::WrapCGI#L87. CGI::Emulate::PSGI writes the response to a temporary file before returning the response (as per https://metacpan.org/release/CGI-Emulate-PSGI/source/lib/CGI/Emulate/PSGI.p…) If you look at CGI::Emulate::PSGI::Streaming (https://metacpan.org/release/CGI-Emulate-PSGI-Streaming/source/lib/CGI/Emul…) you can see how that handler returns a closure rather than a tuple (as noted at http://www.catalystframework.org/calendar/2013/10) In order to do a streaming response, you need to leverage that $responder coderef in the closure. Of course, this should be doable. I have an idea germinating. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #175 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I retested and added a little follow-up for the indirect object notation :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112129|0 |1 is obsolete| | --- Comment #174 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 112135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112135&action=e… Bug 11299: Fix indirect object notation Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112128|0 |1 is obsolete| | --- Comment #173 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 112134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112134&action=e… Bug 11299: (follow-up) correct link Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112127|0 |1 is obsolete| | --- Comment #172 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 112133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112133&action=e… Bug 11299: (follow-up) Skip fields with no 9 subfields To test: 1 - Disable the 'thesaurus' for a controlled field like 600a or 650a 2 - Edit a record and put random data in this field 3 - Try to link, get a JS error 4 - Apply patch 5 - Repeat 6 - No more error, field is not linked (as it has no $9 subfield) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112126|0 |1 is obsolete| | --- Comment #171 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 112132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112132&action=e… Bug 11299: (follow-up) Correct rebase errors and add message class to dialog Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '20

22 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112125|0 |1 is obsolete| | --- Comment #170 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 112131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112131&action=e… Bug 11299: (QA follow-up) Fix tests, spaces, and CSS update Removed my from variables in test Undid stray line deletions Undid adding 1; to test file Fix CSS replace command Update license Fix spelling Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0