November 2020 - Koha-bugs - lists.koha-community.org

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #30 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 113134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113134&action=e… Bug 7607: (follow-up) Disable rather than remove inputs -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #29 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 113133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113133&action=e… Bug 7607: Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Cook <dcook(a)prosentient.com.au> https://bugs.koha-community.org/show_bug.cgi?id=7606 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26803] New: Fix PLUGIN_DIR when plugin_dirs is multivalued
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Bug ID: 26803 Summary: Fix PLUGIN_DIR when plugin_dirs is multivalued Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org When plugin_dir koha-conf.xml parameter contains more than one directory, PLUGIN_DIR parameter sent to templates doesn't contain the proper value, ie the base directory of the current plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 16696] Rename "Publisher" on detail and result lists
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #13) > Created attachment 113125 [details] [review] > Bug 16696: Fix search_utf8.t Patch pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16696] Rename "Publisher" on detail and result lists
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 113125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113125&action=e… Bug 16696: Fix search_utf8.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #46 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 113121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113121&action=e… Bug 14708: (QA follow-up) Add tests This patch adds tests for the change. It also simplifies the delete() method structure a bit. It fixes the error 500 the tests were raising. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! The new behaviour (code 403) is tested! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #45 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #43) > There is a test failing however: > > # Failed test 'Patron not found' > # at t/db_dependent/api/v1/patrons.t line 423. > # got: '500' > # expected: '404' > > > And a test missing to cover the change from the last patch. BTW: I love tests :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8753] Add forgot password link to OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 [Bug 26941] Missing OPAC password recovery error messages -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #44 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #42) > Having this code into master won't help anything: it will have to be rebuilt > as it cannot be used as a good base. > > I am willing to push this patchset as it, given the low bug number (but not > sure it's a good argument...) The argument is, this is a bugfix. And refactoring things the way they are discussing is a good path forward. But it won't happen in stable for a while. -- You are receiving this mail because: You are watching all bug changes.

1 0