November 2020 - Koha-bugs - lists.koha-community.org

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- There is a test failing however: # Failed test 'Patron not found' # at t/db_dependent/api/v1/patrons.t line 423. # got: '500' # expected: '404' And a test missing to cover the change from the last patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Having this code into master won't help anything: it will have to be rebuilt as it cannot be used as a good base. I am willing to push this patchset as it, given the low bug number (but not sure it's a good argument...) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26938 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 [Bug 26938] Prevent flash of unstyled content on sales table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 [Bug 26939] Account payment_type in the cash register details page should use description instead of code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 [Bug 26938] Prevent flash of unstyled content on sales table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen <emmi.takkinen(a)outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #20 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Created attachment 113100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113100&action=e… Bug 12133: Enforce guarantor restrictions on Koha::Patron->store() This patch adds checks for new guarantor requirements to Koha::Patron->store(). If requirements aren't met exception is raised. To test prove t/db_dependent/Koha/Patron.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #19 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Finally had time to look at this again and noticed that the latest patch didn't take into account possible multiple guarantor ids. It fixed issue with modifying but one could add child patron as guarantor. Since these stem up from same a problem, missing guarantor ids, I obsoleted the latest patch and provided a new one which fixes both of these issues. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen <emmi.takkinen(a)outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99629|0 |1 is obsolete| | --- Comment #18 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Created attachment 113099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113099&action=e… Bug 12133: Fix issues with modifying child patron and adding guarantors Child patrons couldn't be modified when guarantor was patron due missing guarantor_id value. Also if multiple guarantors were added one could easily add child patron as a guarantor. This patch adds Instead of one guarantor id all new and existing guarantor ids are checked in case of child patron. To test: 1. Add child patron with syspref ChildNeedsGuarantor and GuarantorNeedsToBePatron on. 2. Add two guarantors for the patron, first one should be an adult patron and second a child. 3. Save patron. => Error "A guarantor cannot be a guarantee." should be raised but isn't. 4. Modify patron and save. => Error "Child needs guarantor" is raised even if (valid) guarantor exists. 5. Apply patch. 6. Repeat steps 1 to 4. => This time while saving a new patron error "A guarantor cannot be a guarantee." is raised but modifying is successful. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart(a)bugs.koha-c |nick(a)bywatersolutions.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes.

1 0