November 2020 - Koha-bugs - lists.koha-community.org

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #26 from David Cook <dcook(a)prosentient.com.au> --- Ok this issue is really annoying me, so let's get it sorted... Test plan: 0. No patch 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1 2. Change 2nd "Keyword" and 3rd "Keyword" to "Author" 3. Change 2nd search box to "Martin" and 3rd search box to "Humble" 4. Change 2nd op box (between Martin and Humble) to "or" 5. Click "Search" 6. Note the following URL: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=kw&o… 7. Note the HTML response: No results match your search for 'kw,wrdl: Martin and au,wrdl: Humble'. Test plan: 0. Apply Nick's patch and "koha-plack --restart kohadev" 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?expanded_options=1 2. Change 2nd "Keyword" and 3rd "Keyword" to "Author" 3. Change 2nd search box to "Martin" and 3rd search box to "Humble" 4. Change 2nd op box (between Martin and Humble) to "or" 5. Click "Search" 5b. If you have a quick eye, you'll see the empty search box was removed by Javascript. Yay! 6. Note the following URL: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=au&q… 7. Note the HTML response: 12 result(s) found for 'au,wrdl: Martin or au,wrdl: Humble'. Great patch, Nick! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112912|0 |1 is obsolete| | --- Comment #25 from David Nind <david(a)davidnind.com> --- Created attachment 112963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112963&action=e… Bug 7607: [Alternate] Remove empty inputs when submitting search form This patch surrounds the operator, index, and query fields on the advanced search page wtih a 'search_set' class. This allows us to process them as a group and confirm the query is populated before submitting the other parts to the form TO test: 1 - Go to advanced search 2 - Use search boxes to search like: Title: (leave blank) Author: clinton keyword: shuffle 3 - Perform search 4 - Note no results as you searched for title:clinton etc. 5 - apply patch 6 - refresh and repeat 7 - search is now correct 8 - Try vaeious searches with 'more options' and selecting different operators Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #24 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 112912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112912 Bug 7607: [Alternate] Remove empty inputs when submitting search form Review of attachment 112912: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=760…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ +140,5 @@ > + if( $(this).find('input[name="q"]').val() == "" ){ > + $(this).remove(); > + removedPrior = true; > + } > + }); I haven't tested the code but what about the idx? Wouldn't this code exacerbate the problem? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #58 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- I applied your patches, updated the database, and restarted services. I then edited my All/All rule for all libraries and saved it as Has Priority. Then I copied my All/All rule for all libraries to one of my branches. After doing that, I am unable to save changes to any of my circ rules. I cannot save edits my branch rules or my all libraries rules. When I click Save, the values revert back to their original values and I get this error in the plack log: [2020/11/03 17:19:17] [WARN] DBD::mysql::st execute failed: Unknown column 'me.has_priority' in 'field list' [for Statement "SELECT `me`.`id`, `me`.`branchcode`, `me`.`categorycode`, `me`.`itemtype`, `me`.`has_priority`, `me`.`rule_name`, `me`.`rule_value` FROM `circulation_rules` `me` WHERE ( ( `me`.`branchcode` IS NULL AND `me`.`rule_name` = ? ) )" with ParamValues: 0='refund'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #30 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 112936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112936&action=e… Bug 14866: Trivial code simplification -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 [Bug 14866] Make high holds work with different item types and number of open days -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Please don't forget to describe what the new enhancement is supposed to add when you write the commit message. The title and test plan are, most of the time, not enough. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '20

03 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table -- You are receiving this mail because: You are watching all bug changes.

1 0