December 2020 - Koha-bugs - lists.koha-community.org

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #25) > (In reply to Aleisha Amohia from comment #17) > > Starting with GetMarcAuthors at Bug 27266 > > Are you sure you will want to reuse that from the template notice? > It seems that to answer bug 17868 you will only need to loop over the MARC > subfields (for instance GetMarcAuthors is building links we don't need). > > Additional questions: should not we take advantage of the move to fix the > inconsistencies in the return values? > > I don't think "just moving" code from C4 to Koha is sufficient. To further simplify things we could let go of the marcflavour parameter as this only seems to be used in context where the marcflavour of the installation is used. I think another question is if we are using them only for the notices or to replace all calls to templates - if we want to replace the other calls, we'd need to keep the links etc. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #17) > Starting with GetMarcAuthors at Bug 27266 Are you sure you will want to reuse that from the template notice? It seems that to answer bug 17868 you will only need to loop over the MARC subfields (for instance GetMarcAuthors is building links we don't need). Additional questions: should not we take advantage of the move to fix the inconsistencies in the return values? I don't think "just moving" code from C4 to Koha is sufficient. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #18) > GetMarcNotes at Bug 27268 No occurrences of "GetMarcNotes" from send-basket and send-shelves scripts. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #23 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #20) > GetMarcSeries at Bug 27270 This is not used and is not needed from send-basket and send-shelves scripts. (ie. no "MARCSERIES" in templates) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8976] Default sequence of subfields in cataloguing editor
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #21) > I agree with Jonathan in that we should never change the sequence of > subfields in an existing bibliographic record - imported or already in Koha. > MARC requires some subfields to be in a specific sequence that is not > alphabetical or easy to guess. Thanks for the confirmation. > I am not sure how the item forms are build in several places - only that the > ones in acq and serials are "different" and have not all features from the > frameworks. Maybe worth checking those for a separate bug. But I think this > one here aims mostly at bibliographic and authority records? Items as well. Item add/mod form from cataloguing and acq are taken into account in those patches. Thanks Michal for the signoff! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27275] New: Hiiiii
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27275 Bug ID: 27275 Summary: Hiiiii Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs(a)lists.koha-community.org Reporter: vicenteuserwin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 114507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114507&action=e… HACKED BY KENZY -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #219 from David Cook <dcook(a)prosentient.com.au> --- Julian, what's the commit that these are based off? I'd love to apply these to a stable base so that I could get a sense of the changes... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #225 from David Cook <dcook(a)prosentient.com.au> --- Trying to find a base to merge these into easily so I can squash them and it's tough. 18.11, 19.05, 19.11... I never knew that Koha's holds code was changed so frequently. Aleisha, even if you don't squash them, could you let me know the parent commit for these patches from your last rebase? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #218 from David Cook <dcook(a)prosentient.com.au> --- Is it possible to squash these patches down a bit? With 16 patches, I think it's difficult to rebase and difficult to have a cohesive idea of how this change is supposed to work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '20

18 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #224 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #223) > Would it be possible to get squash these patches? I think rebasing 13 > patches where the first one is failing is going to be not a very pleasurable > task. > > It looks like these are the files changed: > > Koha::Biblio.pm > MultiplePerRecord.t > Reserves.pm > opac-reserve.pl > opac-reserve.tt > opac.scss > placerequest.pl > request.pl > request.tt -- You are receiving this mail because: You are watching all bug changes.

1 0