December 2020 - Koha-bugs - lists.koha-community.org

[Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPACHiddenItems show in |Placing hold on specific |OPAC when patron places a |items doesn't enforce |hold on a specific item |OpacHiddenItems -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #23 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 114191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114191&action=e… Bug 15448: (QA follow-up) Move fetching the rules outside the loop -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #22 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 114189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114189&action=e… Bug 15448: (follow-up) Fetch the patron category once -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #21 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 114188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114188&action=e… Bug 15448: Filter out items hidden in OPAC on placing hold This patch leverages on bug 24254's Koha::Items->filter_by_visible_in_opac to filter out items that shouldn't be presented to the end user in the OPAC interface. To test: 1. Circulation and Fine rules for item-level holds are set to allow. 2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]" 3. An item with collection Code Suppress is set. 4. Search for the title in the OPAC. => SUCCESS: The Suppress ccode item isn't shown. 5. View the detail page for the title. => SUCCESS: The suppress ccode item isn't shown. 6. Place a hold on the item: -- Click "Show more options" -- Select "A specific item" => FAIL: the ccode with the opachiddenitems rule has an item that appear in the list to place a hold 7. Apply this patch and repeat 6 => SUCCESS: The item doesn't show! 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '20

04 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0