February 2020 - Koha-bugs - lists.koha-community.org

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Housekeeping for bug 23290 |Koha::XSLT housekeeping for |(follow-up) |bug 23290 (follow-up) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- What do others think? Could we get your opinions? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #5 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 99689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99689&action=ed… Bug 24052: Add koha_xslt_security to koha-conf.xml The line for enabling the unsafe expand_entities option is commented and includes a warning to keep it like that ;) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #4 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 99688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99688&action=ed… Bug 24052: Catch warning between test 6 and 7 Resolve: ok 6 - Engine returns error on undefined text XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214. ok 7 - Engine returns error on empty string Test plan: Run perl Base.t and verify that this warning is no longer printed. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #3 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 99687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99687&action=ed… Bug 24052: Fix Koha/XSLT/Base.t Moving the separate small attachments into the test script. Creating them now as temporary files. Deleting original files. Since Breeding.t also used one of these files, a similar change was made in that script. Test plan: Run t/db_dependent/Koha/XSLT/Base.t. Should pass now. Run t/db_dependent/Breeding.t again. Git grep on XSLT_Handler. You should only find release notes. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #2 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 99686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99686&action=ed… Bug 24052: Rename XSLT_Handler Should be XSLT::Base now. Removes old XSLT_Handler stub too (from bug 23290). Result of a git grep | sed statement. Test plan: Run qa tools (so modules compile). Run t/db_dependent/Breeding.t Run t/db_dependent/Koha/XSLT/Base.t (This test fails when only this patch has been applied; see subsequent patch.) Enable XSLT use on results and details display. Check search results and detail view on OPAC and staff. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5103] Dates in MARC details not formatted correctly
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5103 paxed <pasi.kallinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen(a)koha-suomi.fi --- Comment #4 from paxed <pasi.kallinen(a)koha-suomi.fi> --- The same if-block is repeated three times, in different files. This is very fragile and error prone. Should create a sub in one place (Koha::DateUtils maybe), and just call that instead. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99677|0 |1 is obsolete| | --- Comment #104 from David Nind <david(a)davidnind.com> --- Created attachment 99685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99685&action=ed… Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results Also adding missing filters ALSO ensuring you can switch back to library default on staff side Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '20

27 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98365|0 |1 is obsolete| | --- Comment #103 from David Nind <david(a)davidnind.com> --- Created attachment 99684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99684&action=ed… Bug 14715: Results per page dropdown for catalogue search This patch utilises an unused search facet to handle results shown per page. Sponsored-by: Region Halland Signed-off-by: Gabriel DeCarufel <gabriel(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0