February 2020 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart(a)bugs.koha-c |aleisha(a)catalyst.net.nz |ommunity.org | Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have attached few follow-ups, pick the ones you need/want. However I am a bit at lost here. There is no UI so far, but we have such things: + status varchar(1) NOT NULL default 'N', -- status of the report. N=new, V=viewed, C=closed so the status will never be updated, what will happen when we will have the UI? IMO we should bring the UI with that patchset, and remove the notice. Do we really want the notice to be sent? If yes, do we really want the new table? :) Also, do we really need the problem_reports.recipient DB field if we have the email? Same for username? We have the borrowernumber. About the DB structure again, it seems that status should be an ENUM. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99639&action=ed… Bug 4461: Better error handling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99638&action=ed… Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99637&action=ed… Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99636&action=ed… Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99635&action=ed… Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleisha(a)catalyst.net.nz |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Failed QA |ASSIGNED --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am trying to submit follow-ups. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Some notes: 1. reportdate must be created_on, with a type "timestamp". 2. opac/opac-reportproblem.pl 112 my $from_address = $member->email || $member->emailpro || $member->B_email || $koha_admin; We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99633&action=ed… Bug 4461: Rename report date with created_on And make it a timestamp type column -- You are receiving this mail because: You are watching all bug changes.

1 0