February 2020 - Koha-bugs - lists.koha-community.org

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #55 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99152&action=ed… Bug 15522: Add yarn.lock (autogenerated) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #54 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99151&action=ed… Bug 15522: Remove old circulation rules interface -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99150&action=ed… Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #52 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99149&action=ed… Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #51 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99148&action=ed… Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking when not using QueryParser
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #43 from David Cook <dcook(a)prosentient.com.au> --- Whoa... added unit tests when UseQueryParser is enabled and it's giving unpredictable results. Half the time, the expected result is correct and half the time it is wrong. It looks like it's swapping the order of the operands around. Bizarre. # got: '@or @or @attr 1=1016 @attr 5=1 @attr 4=6 "test" @attr 2=102 @attr 9=34 @attr 5=1 @attr 4=6 "test" @attr 2=102 @attr 9=20 @attr 5=1 @attr 4=6 "test"' # expected: '@or @or @attr 1=1016 @attr 5=1 @attr 4=6 "test" @attr 2=102 @attr 9=20 @attr 5=1 @attr 4=6 "test" @attr 2=102 @attr 9=34 @attr 5=1 @attr 4=6 "test"' I don't know what to do about that... it'll unpredictably bust the tests on master, but it is arguably a problem with the QueryParser or at least a problem of evaluating the query based on string matching instead of parsing the query and analyzing it logically... I think I'll leave out that test for now... especiallys ince we are planning to remove the QueryParser... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24213] New: Koha::Object->get_from_storage should return undef if the object has been deleted
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213 Bug ID: 24213 Summary: Koha::Object->get_from_storage should return undef if the object has been deleted Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org It currently explodes with something like: DBIC result _type isn't of the _type Subscription at t/db_dependent/Biblio.t line 627. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 12430] Search truncation disables relevance ranking when not using QueryParser
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #42 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #41) > Created attachment 99142 [details] [review] > First Draft buildQuery unit test This isn't complete yet, but it's a first pass before I have to run out of the office for a few hours. I need to add more permutations to the tests: 1. like a query with no * or QueryAutoTruncate to see if QueryWeightFields still works 2. like a more complex CCL/CCLish query 3. Turn on UseQueryParser (even if I think we should soon remove QueryParser from Koha) 4. Add limits to the unit tests Note that buildQuery spits out a lot of warnings, but I don't think they're relevant for this test. Rather, I think they're just indicative that buildQuery isn't very well written. Of course, these unit tests could be the basis for improving it. Thanks, Jonathan, for poking me on this one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking when not using QueryParser
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #41 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 99142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99142&action=ed… First Draft buildQuery unit test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking when not using QueryParser
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #40 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Jonathan Druart from comment #36) > Can you put commit title and bug report title in sync please? Ok hopefully this is more in line with what you were thinking. > I guess nobody will have time to provide tests to cover this change? I'm going to try to do this now in the next 20 minutes... -- You are receiving this mail because: You are watching all bug changes.

1 0