February 2020 - Koha-bugs - lists.koha-community.org

[Bug 12430] Search truncation disables relevance ranking when not using QueryParser
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98619|0 |1 is obsolete| | --- Comment #39 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 99141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99141&action=ed… Bug 12430: Force relevance ranking when not using QueryParser The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto 2) Turn off "UseQueryParser" 3) Do a keyword search in the OPAC 4) Note that the results are ordered by biblionumber ascending 5) Apply patch 6) Do the same keyword search in the OPAC 7) Note that the results are never ordered differently (presumably in relevance order :P) If you're a stickler, throw in some warns so that you can see what CCL query is being sent to Zebra. Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking when not using QueryParser
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search truncation disables |Search truncation disables |relevance ranking |relevance ranking when not | |using QueryParser --- Comment #38 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Jonathan Druart from comment #36) > Can you put commit title and bug report title in sync please? > Actually, I'm not 100% sure what you mean by this, but I'm going to -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using QueryAutoTruncate |Search truncation disables |breaks relevance ranking |relevance ranking -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24330] New: When importing patrons from CSV, automatically strip BOM from file if it exists
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 Bug ID: 24330 Summary: When importing patrons from CSV, automatically strip BOM from file if it exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org We have a partner that exports UTF-8 CSV files, and is experiencing the same thing as the author of this article: https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-cha… In short, Excel is inserting an invisible UTF-8 character at the start of the file, so that the column name "cardnumber" is actually named "\x{feff}cardnumber", causing "cardnumber" to be blank. A simple solution is provided here: https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-pe… -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #37 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 81125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81125 Bug 21311: (follow-up) Adjust wording of failed login message Review of attachment 81125: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=213…) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt @@ +168,4 @@ > </fieldset> > > <input type="submit" value="Log in" class="btn" /> > + <p/> I think this must've been a typo. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23896] New: logaction should pass the correct interface to Koha::Logger
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896 Bug ID: 23896 Summary: logaction should pass the correct interface to Koha::Logger Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Look at my $logger = Koha::Logger->get( { interface => 'intranet', while we have $interface //= C4::Context->interface; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 12430] Using QueryAutoTruncate breaks relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '20

18 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #37 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Jonathan Druart from comment #36) > Can you put commit title and bug report title in sync please? > > I guess nobody will have time to provide tests to cover this change? Well when you put it that way... hehe. I'll put it on my TODO list for tonight. I have a few patches I want to do tonight, so I'll try to get them all done at once. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '20

17 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #50 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Ahh, that makes sense. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '20

17 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #49 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Hayley, I think this has a remote branch to be used instead of attached patches: https://gitlab.com/joubu/Koha/commits/bug_15522 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '20

17 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley(a)catalyst.net.n | |z --- Comment #48 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Hi, Are any of the obsoleted patches here supposed to be not obsoleted? I see this Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0