February 2020 - Koha-bugs - lists.koha-community.org

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #97 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 98703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98703&action=ed… Bug 8643: code cleanup Merges "AreMandatoriesNotOk" and new "AreImportantsNotOk" into one function "AreFieldsNotOk". It can search for mandatory or important fields depending on the value of it's boolean "mandatory" parameter. To test: This patch should not change current behavior. Follow the test plan from previous patch and check that saving is still prevented for unfilled mandatory fields. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98607|0 |1 is obsolete| | Attachment #98608|0 |1 is obsolete| | --- Comment #96 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 98702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98702&action=ed… Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Tested on update and new install, works as described. No errors. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Amended-patch: Remove the schema change -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12410] Remove useless use of cookies
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12410 --- Comment #2 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Cookies are returned to the server, then back to the client. I do not think we should use them when not needed, here it is only needed client-side, and can be replaced with local storage. Also, privacy, useless data going through the network, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 22331] New: Lost items that are written off gives credit when returned
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Bug ID: 22331 Summary: Lost items that are written off gives credit when returned Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: bdaeuber(a)cityoffargo.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- When a lost item is written off by the library, but later returned, Koha gives a credit for that item. To recreate: 1. Ensure "Refund lost item fee" is set to "Yes" in Circulation and Fine Rules. 2. Check out an item to a patron. 3. Mark item as lost. Replacement price should be added to their account. 4. Write off the fee. 5. Return the item. A refund is generated. A write off should not generate a refund in this situation. Is it possible this is related to Bug 19919 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 9805] Lost items are un-lost if returned, but not if renewed
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4985] Edit a calendar entry for all branches
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 --- Comment #12 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- > I'm new to this signing off thing and may have overstepped what is expected of me. Not at all and I'm sorry if my answer made you feel that way. Just wanted to make sure if I understood last part of your comment correctly :) Your comment was totally valid and in my opinion it pointed out possible need for enhancement. I say "in my opinion" since I have no idea if this edit is intended to affect only single days or not and should it be fixed. To make it clear, this patch just adds functionality to copy edits and deletes to all branches at once just the way holidays can be copied to all branches when they are created. So if the changes that are made for single branch are copied to every other branch this patch works as it's intended. I'm still unable to repeat problem with delete as in Katrins screenshot. I added and copied holidays on a range, then deleted them on a range and copied change to all libraries. Delete worked without problem also for the single, weekly, yearly and exception holidays. So Katrin, I have no idea why it's not working you :/ -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 9097] 'Welcome mail' for new library users
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24111] New: Incorrect "Can't create any orders" alert
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Bug ID: 24111 Summary: Incorrect "Can't create any orders" alert Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org It happens to see "You can't create any orders unless you first define a budget and a fund" when adding a new order. The test on neworderbiblio.pl is not the same as other pages. We should test if the logged in user can use the budget, not if they are the owner. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 98697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98697&action=ed… Bug 8132: Adding message when deleting from the UI -- You are receiving this mail because: You are watching all bug changes.

1 0