February 2020 - Koha-bugs - lists.koha-community.org

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #49 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 98696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98696&action=ed… Bug 8132: Delete the items in a transaction and rollback if something wrong The last_item_for_hold case cannot be guessed (easily), and so we are going to delete the items in a transaction. If something wrong happened we rollback and display a list of items that caused the rollback. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 98695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98695&action=ed… Bug 8132: Adding a new message 'last_item_for_hold' blocking item deletion If an item is the last one of a biblio that have biblio-level hold placed on it, we should block the deletion. It takes effect if the hold is found (W or T), to follow existing behavior for item-level holds. If we want to block deletion for any holds we should deal with it on a separate bug report. Test plan: 0/ Setup Create Biblio B1 with 1 item Create Biblio B2 with 2 items Create Biblio B3 with 1+ item Create Biblio B4 with 1+ item Create Biblio B5 with 1+ item Place a biblio-level hold on B1 and B2 Place an item-level hold on B3 and B4 Confirm the item-level hold for the items of B3 to mark it waiting. 1/ Delete those 6 items in a batch => delete of item from B1 is blocked on first screen - only 1 item left and there is a biblio-level hold on the record => delete of items from B2 is *not* blocked on first screen - One of them will block the deletion, but so far we are not aware of that situation => delete of item from B3 is blocked on first screen - there is a waiting item-level hold placed on the item => delete of item from B4 is *not* blocked - there is a hold but it is not found => delete of item from B5 is *not* - there is no reason to block its deletion Note that you can only select items from B2, B4 and B5 2/ Select them and confirm the deletion => Nothing happened and you get a message saying that one of the 2 items from B2 is blocking the whole deletion process 3/ Remove the biblio-level hold 4/ Repeat 1 => The deletion has been effective! => Note that there is something a bit weird as we are blocking items from a biblio that has biblio-level holds on it (not found), but we do not blocking the deletion of an item with a waiting item-level hold -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96147|0 |1 is obsolete| | Attachment #96148|0 |1 is obsolete| | Attachment #96149|0 |1 is obsolete| | Attachment #96150|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 98694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98694&action=ed… Bug 8132: No changes but disable checkboxes When the list of items is displayed we already know if there will be a problem during the deletion. So let's disable the checkbox to tell the user in advance that items cannot be deleted. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #20 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 98689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98689&action=ed… Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66324|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 98688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98688&action=ed… Bug 4461: Problem Report Koha objects -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66323|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 98687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98687&action=ed… Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24595] New: Warnings displayed by Circulation.t
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24595 Bug ID: 24595 Summary: Warnings displayed by Circulation.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org kohadev-koha@9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 1/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. t/db_dependent/Circulation.t .. 15/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549. t/db_dependent/Circulation.t .. 18/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549. Use of uninitialized value $due in concatenation (.) or string at /kohadevbox/koha/C4/Overdues.pm line 601. Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549. t/db_dependent/Circulation.t .. 27/46 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297. Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297. Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297. Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297. t/db_dependent/Circulation.t .. 30/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. t/db_dependent/Circulation.t .. 31/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787. t/db_dependent/Circulation.t .. 38/46 Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Circulation.pm line 962. t/db_dependent/Circulation.t .. 44/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549. Use of uninitialized value $due in concatenation (.) or string at /kohadevbox/koha/C4/Overdues.pm line 601. t/db_dependent/Circulation.t .. ok All tests successful. Files=1, Tests=46, 32 wallclock secs ( 0.07 usr 0.01 sys + 20.75 cusr 7.61 csys = 28.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 24525, which changed state. Bug 24525 Summary: Hide SIP payment types from the Point of Sale page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24526] Auto renewal cronjob should have verbose and test mode options
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '20

11 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy(a)bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #19 from Joy Nelson <joy(a)bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

1 0