March 2020 - Koha-bugs - lists.koha-community.org

[Bug 24051] New: batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Bug ID: 24051 Summary: batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \\%condition ) instead at /kohadevbox/koha/Koha/Objects.pm line 136: /kohadevbox/koha/tools/batchMod.pl, referer: http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phas… -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 16763] New: Remove the use of "onclick" from record matching rules form
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16763 Bug ID: 16763 Summary: Remove the use of "onclick" from record matching rules form Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/matching-rules.pl?op=edit_matching _rule&matcher_id=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, hector.hecaxmmx(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, testopia(a)bugs.koha-community.org Depends on: 16762 Status: Needs Signoff Patch complexity: Small patch Attachment #52499 1 is obsolete: CC: hector.hecaxmmx(a)gmail.com Status: Signed Off Status: Failed QA CC: jonathan.druart(a)bugs.koha-community.org Status: ASSIGNED There are many uses of "onclick" in the record matching rules edit form. These should be removed in favor of defining events in JavaScript. --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 52499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52499&action=ed… Bug 16763 - Remove the use of "onclick" from record matching rules form This patch revises the record matching rules edit form to remove the use of "onclick" in favor of defining events in JavaScript. Also changed: Custom form validation JS is replaced by use of the built-in validation plugin; Font Awesome icons are added to 'add' and 'remove' links. To test, apply the patch and go to Administration -> Record matching rules. - When adding or editing a record matching rule, the description, match threshold, and record type should be required. - With both match points and match checks, the "add" and "remove" links should work correctly to show a new section with a blank form. "Add" and "remove" links should work correctly whether the form is in a saved state (i.e. the saved data has just been opened for editing), or whether the links have been added to the page as part of an "add" operation. - When adding a match point or a match check, data added in additional entries should be saved correctly. - After removing a match point or match check, the data should be saved correctly. --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 53004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53004&action=ed… [SIGNED-OFF]Bug 16763: Remove the use of "onclick" from record matching rules form This patch revises the record matching rules edit form to remove the use of "onclick" in favor of defining events in JavaScript. Also changed: Custom form validation JS is replaced by use of the built-in validation plugin; Font Awesome icons are added to 'add' and 'remove' links. To test, apply the patch and go to Administration -> Record matching rules. - When adding or editing a record matching rule, the description, match threshold, and record type should be required. - With both match points and match checks, the "add" and "remove" links should work correctly to show a new section with a blank form. "Add" and "remove" links should work correctly whether the form is in a saved state (i.e. the saved data has just been opened for editing), or whether the links have been added to the page as part of an "add" operation. - When adding a match point or a match check, data added in additional entries should be saved correctly. - After removing a match point or match check, the data should be saved correctly. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as advertised --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Owen, if you add a rule without match point and then edit it again to add one, clicking on "Add match point" won't display the form. --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Jonathan Druart from comment #3) > Owen, if you add a rule without match point and then edit it again to add > one, clicking on "Add match point" won't display the form. Is this what you're describing? 1. Click 'New record matching rule' 2. Fill in all the required fields at the top, but no match points or match checks. 3. Save the rule. 4. Edit the rule you just created. 5. Click the 'Add match point' link --> The Match point 2 form doesn't display? Step 5 works correctly for me, so I'm not sure I understand the problem. --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Owen, So yes it is displayed, but at the bottom under the "match checks" block. Actually the "match checks" block is contained into the "match points" block when there is no match points. They are 2 different blocks when you add a new rule or edit a rule with match points. --- Comment #6 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 54487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54487&action=ed… Screenshot of step 5 as described in Comment 4 Here's what I see after step 5 as described in Comment 4. Is that what you're seeing? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16762 [Bug 16762] Record matching rules: Remove match check link removes too much -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 24898] New: AddIssue destructively changes transfers
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24898 Bug ID: 24898 Summary: AddIssue destructively changes transfers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 24298 As highlighted in a comment on bug 24298, AddIssue can destructively cancel transfers. The transferto field is forcefully overriden and the reason isn't recorded. We should handle this in a clearer way.. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 [Bug 24298] Record if a transfer was triggered by 'return to homebranch' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 6664] Allow to set a weekly holiday for a given data range
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6664 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24238] New: GET /biblios does not default to accept:application/json
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24238 Bug ID: 24238 Summary: GET /biblios does not default to accept:application/json Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org Depends on: 23677 The accept header value has to be set, it does not default to application/json like the other routes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 [Bug 23677] Add API route to get a bibliographic record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 17221] New: orphan comma in shelf browser
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221 Bug ID: 17221 Summary: orphan comma in shelf browser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org Created attachment 54997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54997&action=ed… screenshot of bug Example screenshot attached, here's the bib record in our catalog: https://library.cca.edu/cgi-bin/koha/opac-detail.pl?biblionumber=21729&shel… Basically, since starting_homebranch is null in the template file, nothing is printed out, but the next IF condition wrongly assumes that the first must have been true and prints out a comma before it's text string. Steps to recreate: - in settings, set ShelfBrowserUsesHomeBranch to "Don't Use" - set ShelfBrowserUsesLocation to "Use" - visit an item, click the "Browse shelf" link in the Holdings' tab's Call Number column - note the extraneous comma in the <h5> tag that appears Patch coming shortly, it appears that simply adding an additional condition around the comma itself should resolve this problem. -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 24110] New: Template vars are incorrectly html filtered when dumped
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Bug ID: 24110 Summary: Template vars are incorrectly html filtered when dumped Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13618 Referring to DumpTemplateVarsIntranet and DumpTemplateVarsOpac Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 24514] New: Holds Awaiting Pickup sorting by title before surname
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514 Bug ID: 24514 Summary: Holds Awaiting Pickup sorting by title before surname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 24024 fixed an error causing Holds Awaiting Pickup to sort by firstname rather than firstname. However, it's now sorting by title, then surname, then firstname. To test: - generate and capture a hold for a patron named "Mr. A A" - generate and capture a hold for a patron named "A A" - generste and capture a hold for patron named "Mr. B B" - generste and capture a hold for patron named "B B" - go to holds awaiting pickup - sort by patron name ascending - holds sort Mr. A, Mr. B, A, B - sort by patron name descending - holds sort B, A, Mr. B, Mr. A -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 18933] New: Unable to set SMS number in OPAC messaging preferences to empty
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18933 Bug ID: 18933 Summary: Unable to set SMS number in OPAC messaging preferences to empty Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org This is inconsistent with the Staff Client side, where the SMS number can be set to empty. Also I think that since this is borrower information, it should be their choice whether they provide this info or not and should have the ability to remove it -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 24388] New: Unless test in acqui/lateorders.tt
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '20

18 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388 Bug ID: 24388 Summary: Unless test in acqui/lateorders.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 24162 The budget_lock is never set (and has never been): [% UNLESS lateorder.budget_lock %] <input type="submit" class="btn btn-default" value="Claim order" /> [% END %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162 [Bug 24162] Late orders improvements - display new columns -- You are receiving this mail because: You are watching all bug changes.

1 15