March 2020 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99938|0 |1 is obsolete| | --- Comment #79 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 100493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100493&action=e… Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99937|0 |1 is obsolete| | --- Comment #78 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 100492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100492&action=e… Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99936|0 |1 is obsolete| | --- Comment #77 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 100491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100491&action=e… Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99935|0 |1 is obsolete| | --- Comment #76 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 100490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100490&action=e… Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99934|0 |1 is obsolete| | --- Comment #75 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 100489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100489&action=e… Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99933|0 |1 is obsolete| | --- Comment #74 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 100488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100488&action=e… Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24748] New: Workaround to enable installation of 19.11 on Debian 9 is missing from install docs
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24748 Bug ID: 24748 Summary: Workaround to enable installation of 19.11 on Debian 9 is missing from install docs Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: dwight.tuinstra(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This bug relates to these installation documents: - https://wiki.koha-community.org/wiki/Preparing_your_system - https://wiki.koha-community.org/wiki/Koha_on_Debian Since installation on Debian 10 is currently discouraged, I attempted a koha install on a fresh instance of Debian 9, 64-bit (i686) architecture. The problem occurs at the "Install Koha" step (https://wiki.koha-community.org/wiki/Koha_on_Debian#Install_Koha) The command "apt-get install koha-common" fails with the following error message: Reading package lists... Done Building dependency tree Reading state information... Done Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: koha-common : Depends: libnet-oauth2-authorizationserver-perl but it is not going to be installed E: Unable to correct problems, you have held broken packages. This is a known problem, mentioned in bug 23128 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128) The workaround that is suggested there is to enable Debian 9 backports, as follows: 1) Create /etc/apt/sources.list.d/stretch-backports.list with this line: deb http://deb.debian.org/debian stretch-backports main 2) Run apt-get update Running "apt-get install koha-common" will then work. This workaround should be incorporated into the "Koha on Debian" document. Without it, installation fails. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 11529] Add subtitle, medium and part fields to biblio table
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #243 from David Cook <dcook(a)prosentient.com.au> --- Turns out the database update for this change causes unexpected changes to the "Koha to MARC mapping" (via the MARC frameworks) if you had additional non-standard "Koha to MARC mapping" entries. Personally, I wouldn't have updated the marc_subfield_structure automatically. Here's the query used: UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE fieldmapping.frameworkcode=''" This would be a better query: UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE fieldmapping.frameworkcode=''" and field='subtitle' Now I have a lot of different MARC fields mapped to biblio.subtitle 😅 Of course, even the modified query wouldn't be great, because in my case 245$h would get mapped to biblio.title too which isn't what we'd want. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23527] New: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Bug ID: 23527 Summary: BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: techservspec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The url stored in the preference BakerTaylorBookstoreURL is rendered in opac-detail.tt with escaped characters (including the "/", "?" and "=" characters which are designating subdirectories and parameters), thus making the resulting link invalid. For example: The URL used for BakerTaylorBookstoreURL is https://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID= However, what is rendered in the OPAC is https://contentcafe2.btol.com%2FContentCafeClient%2FContentCafe.aspx%3FUser… To test this (requires a Baker & Taylor username and id): 1. Enter contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=(your username)&Password=(your password)&ItemKey= into the BakerTaylorBookstoreURL preference and enable Baker & Taylor images. 2. Display a record that has a cover image in the OPAC. 3. Click on the image. You are not redirected to the above url (in firefox nothing happens, in chrome you are directed to "about:blank#blocked"). -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 24640] New: quotes.timestamp should default to current_timestamp
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Bug ID: 24640 Summary: quotes.timestamp should default to current_timestamp Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The quotes.timestamp column is a datetime without default value. It would be better to have it timestamp default current_timestamp() -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18