March 2020 - Koha-bugs - lists.koha-community.org

[Bug 24640] New: quotes.timestamp should default to current_timestamp
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24640 Bug ID: 24640 Summary: quotes.timestamp should default to current_timestamp Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The quotes.timestamp column is a datetime without default value. It would be better to have it timestamp default current_timestamp() -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Arthur Bousquet <arthur.bousquet(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #23 from Arthur Bousquet <arthur.bousquet(a)inlibro.com> --- Thanks for testing ! Solved the first problem The "Show" button is here if we do a Z3950 search in our own database. We could remove it or make it invisible if it leads to nothing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24825] New: circulation-home.tt is missing [% SET footerjs = 1 %]
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24825 Bug ID: 24825 Summary: circulation-home.tt is missing [% SET footerjs = 1 %] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com circulation-home.tt does not have [% SET footerjs = 1 %], therefore javascript/jQuery are impossible on this page. TO RECERATE: -add this jQuery to IntranetUserJS: $('#logo').hide(); -load the circulation page, it does not hide the logo. -go to any other page on the staff client, the logo is hidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Arthur Bousquet <arthur.bousquet(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100077|0 |1 is obsolete| | Attachment #100463|0 |1 is obsolete| | --- Comment #22 from Arthur Bousquet <arthur.bousquet(a)inlibro.com> --- Created attachment 100470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100470&action=e… Bug 11361 - Fixing database and merge conflicts Bug 11361 - Fixing z3950servers.tt problems Bug 11361 - Re-adding the 'Attributes' column Bug 11361 - Fixing z3950servers.tt problems -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 --- Comment #21 from Arthur Bousquet <arthur.bousquet(a)inlibro.com> --- Created attachment 100463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100463&action=e… Bug 11361 - Fixing z3950servers.tt problems -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #103 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- (In reply to Katrin Fischer from comment #102) > I agree about the tests, but with all the API work - Doesn't it makes sense > to centralize all the checks needed instead of repeating (and forgetting > them) all over the place? The general idea makes sense to me. Thanks for the +1 Katrin, that was definitely the idea behind this patch. While working with library frontend software we (@BibLibre) have stumbled across several checks and behaviors which are different from OPAC to ILS-DI. Centralizing those checks and behaviors makes a lot of sense to me as well with also the Rest API coming if we want to have a bit of coherence across the different entry points of Koha. Also makes the whole thing much easier to maintain I guess. Still I do have a bit of work ahead for the tests. I will try to solve this before the NoHackFest / CanceledHackFest -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #16) > Thx Owen ! > Shall I add your signoff line or would you? Fixed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100409|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 100456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100456&action=e… Bug 24052: Add koha_xslt_security to koha-conf.xml The line for enabling the unsafe expand_entities option is commented and includes a warning to keep it like that ;) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100408|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 100455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100455&action=e… Bug 24052: Catch warning between test 5 and 6 Resolve: ok 5 - Engine returns error on undefined text XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214. ok 6 - Engine returns error on empty string Test plan: Run perl Base.t and verify that this warning is no longer printed. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24052] Koha::XSLT housekeeping for bug 23290 (follow-up)
by bugzilla-daemon＠bugs.koha-community.org 10 Mar '20

10 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24052 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100407|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 100454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100454&action=e… Bug 24052: Fix Koha/XSLT/Base.t Moving the separate small attachments into the test script. Creating them now as temporary files or code fragments. Deleting original files. Since Breeding.t also used one of these files, a similar change was made in that script. Test plan: Run t/db_dependent/Koha/XSLT/Base.t. Should pass now. Run t/db_dependent/Breeding.t again. Git grep on XSLT_Handler. You should only find release notes. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0